Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2528943002: Revert of [heap] Use store buffer for writes coming from mutator. (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Use store buffer for writes coming from mutator. (patchset #6 id:100001 of https://codereview.chromium.org/2528563003/ ) Reason for revert: tsan problems: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/12860 Original issue's description: > Store buffer is used for writes that are coming from the mutator. Writes coming from the GC are directly added to the remembered set. > > BUG=chromium:648568 > > Committed: https://crrev.com/c63c34e12e60ac0a19e1338b647882ac61d08741 > Cr-Commit-Position: refs/heads/master@{#41263} TBR=ulan@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:648568 Committed: https://crrev.com/061c2ab23a1d4cd192b935e7912e7dfb1fed845d Cr-Commit-Position: refs/heads/master@{#41265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -44 lines) Patch
M src/heap/heap.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/heap/heap-inl.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/heap/store-buffer.h View 3 chunks +1 line, -19 lines 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +7 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
Created Revert of [heap] Use store buffer for writes coming from mutator.
4 years ago (2016-11-24 13:49:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528943002/1
4 years ago (2016-11-24 13:49:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 13:49:59 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-24 13:50:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/061c2ab23a1d4cd192b935e7912e7dfb1fed845d
Cr-Commit-Position: refs/heads/master@{#41265}

Powered by Google App Engine
This is Rietveld 408576698