content/browser/service_worker/service_worker_job_unittest.cc - Issue 252893006: Remove the unused source_process_id and provider_host arguments to SW unregistration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_job_unittest.cc

Issue 252893006: Remove the unused source_process_id and provider_host arguments to SW unregistration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_dispatcher_host.cc ('K') | « content/browser/service_worker/service_worker_job_coordinator.cc ('k') | content/public/browser/service_worker_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_job_unittest.cc b/content/browser/service_worker/service_worker_job_unittest.cc

index de5e61283ab82c506a3d6f4816dfcdd3a2748f53..3dee40c0c69052e6d4426b31c3cef33cb26b2db3 100644

--- a/content/browser/service_worker/service_worker_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_job_unittest.cc

@@ -247,7 +247,6 @@ TEST_F(ServiceWorkerJobTest, Unregister) {

ASSERT_TRUE(called);

job_coordinator()->Unregister(pattern,

- render_process_id_,

SaveUnregistration(SERVICE_WORKER_OK, &called));

ASSERT_FALSE(called);

@@ -273,7 +272,6 @@ TEST_F(ServiceWorkerJobTest, Unregister_NothingRegistered) {

bool called;

job_coordinator()->Unregister(pattern,

- render_process_id_,

SaveUnregistration(SERVICE_WORKER_OK, &called));

ASSERT_FALSE(called);

@@ -449,7 +447,6 @@ TEST_F(ServiceWorkerJobTest, ParallelRegUnreg) {

bool unregistration_called = false;

job_coordinator()->Unregister(

pattern,

- render_process_id_,

SaveUnregistration(SERVICE_WORKER_OK, &unregistration_called));

ASSERT_FALSE(registration_called);

@@ -565,14 +562,11 @@ TEST_F(ServiceWorkerJobTest, ParallelUnreg) {

bool unregistration1_called = false;

job_coordinator()->Unregister(

pattern,

- render_process_id_,

SaveUnregistration(SERVICE_WORKER_OK, &unregistration1_called));

bool unregistration2_called = false;

job_coordinator()->Unregister(

- pattern,

- render_process_id_,

- SaveUnregistration(SERVICE_WORKER_OK, &unregistration2_called));

+ pattern, SaveUnregistration(SERVICE_WORKER_OK, &unregistration2_called));

ASSERT_FALSE(unregistration1_called);

ASSERT_FALSE(unregistration2_called);