content/browser/service_worker/service_worker_context_core.cc - Issue 252893006: Remove the unused source_process_id and provider_host arguments to SW unregistration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 252893006: Remove the unused source_process_id and provider_host arguments to SW unregistration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_core.h ('k') | content/browser/service_worker/service_worker_context_unittest.cc » ('j') | content/browser/service_worker/service_worker_dispatcher_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_core.cc

diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc

index 9b8a17a008732d404143b7029701b29baccd6153..924bd7fb19f317d30625b3a5cb5065684d410b58 100644

--- a/content/browser/service_worker/service_worker_context_core.cc

+++ b/content/browser/service_worker/service_worker_context_core.cc

@@ -155,15 +155,10 @@ void ServiceWorkerContextCore::RegisterServiceWorker(

void ServiceWorkerContextCore::UnregisterServiceWorker(

const GURL& pattern,

- int source_process_id,

- ServiceWorkerProviderHost* provider_host,

const UnregistrationCallback& callback) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

- // TODO(kinuko): Wire the provider_host so that we can tell which document

- // is calling .register.

Jeffrey Yasskin 2014/04/29 00:37:09 This looks like a mistake in copy/paste.

- job_coordinator_->Unregister(pattern, source_process_id, callback);

+ job_coordinator_->Unregister(pattern, callback);

}

void ServiceWorkerContextCore::RegistrationComplete(