Remove the unused source_process_id and provider_host arguments to SW unregistration.

Remove the unused source_process_id and provider_host arguments to SW unregistration.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267087

[Jeffrey Yasskin, 2014-04-29 00:37:09]

PTAL

https://codereview.chromium.org/252893006/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_context_core.cc (left):

https://codereview.chromium.org/252893006/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_context_core.cc:164: // is calling
.register.
This looks like a mistake in copy/paste.

https://codereview.chromium.org/252893006/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_dispatcher_host.cc (right):

https://codereview.chromium.org/252893006/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_dispatcher_host.cc:187:
ServiceWorkerProviderHost* provider_host = context_->GetProviderHost(
I left this lookup alone because it looks like the beginning of a security
measure, checking that the unregistration came from the right origin.

[kinuko, 2014-04-29 01:09:16]

Ok... looks like so far we've never needed it.  lgtm

[Jeffrey Yasskin, 2014-04-29 01:11:15]

The CQ bit was checked by jyasskin@chromium.org

[commit-bot: I haz the power, 2014-04-29 01:11:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/252893006/1

[commit-bot: I haz the power, 2014-04-29 01:33:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 01:33:58]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[Jeffrey Yasskin, 2014-04-29 01:50:32]

+jam for the content/public/browser change.

[jam, 2014-04-29 04:15:32]

lgtm

[jam, 2014-04-29 04:15:40]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-04-29 04:16:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/252893006/1

[commit-bot: I haz the power, 2014-04-29 06:08:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 06:08:06]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[Jeffrey Yasskin, 2014-04-29 16:18:13]

The CQ bit was checked by jyasskin@chromium.org

[commit-bot: I haz the power, 2014-04-29 16:19:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/252893006/1

[commit-bot: I haz the power, 2014-04-29 16:19:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 16:19:11]

Failed to apply patch for
content/browser/service_worker/service_worker_context_unittest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
content/browser/service_worker/service_worker_context_unittest.cc
  Hunk #1 FAILED at 269.
  1 out of 1 hunk FAILED -- saving rejects to file
content/browser/service_worker/service_worker_context_unittest.cc.rej

Patch:       content/browser/service_worker/service_worker_context_unittest.cc
Index: content/browser/service_worker/service_worker_context_unittest.cc
diff --git a/content/browser/service_worker/service_worker_context_unittest.cc
b/content/browser/service_worker/service_worker_context_unittest.cc
index
3c7d55f3258d05dce4388e33f978c1e867e244e5..9e61f8088d120c34c9283d257031f3d580f277f5
100644
--- a/content/browser/service_worker/service_worker_context_unittest.cc
+++ b/content/browser/service_worker/service_worker_context_unittest.cc
@@ -269,8 +269,7 @@ TEST_F(ServiceWorkerContextTest, Unregister) {
   EXPECT_NE(kInvalidServiceWorkerVersionId, version_id);
 
   called = false;
-  context_->UnregisterServiceWorker(
-      pattern, render_process_id_, NULL, MakeUnregisteredCallback(&called));
+  context_->UnregisterServiceWorker(pattern,
MakeUnregisteredCallback(&called));
 
   ASSERT_FALSE(called);
   base::RunLoop().RunUntilIdle();

[Jeffrey Yasskin, 2014-04-29 19:17:47]

The CQ bit was checked by jyasskin@chromium.org

[commit-bot: I haz the power, 2014-04-29 19:19:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/252893006/20001

[commit-bot: I haz the power, 2014-04-30 05:27:42]

Change committed as 267087