Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 252893004: Remove SVGElementInstanceList (Closed)

Created:
6 years, 7 months ago by rwlbuis
Modified:
6 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews, krit, arv+blink, fs, watchdog-blink-watchlist_google.com, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Inactive, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove SVGElementInstanceList This is no longer part of SVG2 and we do not use it internally. BUG=313438 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172928

Patch Set 1 #

Patch Set 2 : Add expected results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -165 lines) Patch
M LayoutTests/svg/custom/global-constructors-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/svg/custom/script-tests/global-constructors.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/svg/dom/method-argument-aritychecks.html View 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/svg/dom/method-argument-aritychecks-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/svg/dom/svg2-inheritance.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/svg/dom/svg2-inheritance-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGElementInstance.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElementInstance.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/svg/SVGElementInstance.idl View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/svg/SVGElementInstanceList.h View 1 chunk +0 lines, -46 lines 0 comments Download
D Source/core/svg/SVGElementInstanceList.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
D Source/core/svg/SVGElementInstanceList.idl View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
rwlbuis
PTAL, not sure if an Intent is needed here.
6 years, 7 months ago (2014-04-28 21:32:49 UTC) #1
pdr.
On 2014/04/28 21:32:49, rwlbuis wrote: > PTAL, not sure if an Intent is needed here. ...
6 years, 7 months ago (2014-04-29 03:41:02 UTC) #2
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 7 months ago (2014-04-29 12:31:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/252893004/20001
6 years, 7 months ago (2014-04-29 12:32:00 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 12:51:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink
6 years, 7 months ago (2014-04-29 12:51:10 UTC) #6
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 7 months ago (2014-04-29 13:18:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/252893004/20001
6 years, 7 months ago (2014-04-29 13:18:14 UTC) #8
rwlbuis
The CQ bit was unchecked by rob.buis@samsung.com
6 years, 7 months ago (2014-04-29 16:49:05 UTC) #9
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 7 months ago (2014-04-29 16:49:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/252893004/20001
6 years, 7 months ago (2014-04-29 16:49:38 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 19:19:34 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink
6 years, 7 months ago (2014-04-29 19:19:35 UTC) #13
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 7 months ago (2014-04-29 19:37:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/252893004/20001
6 years, 7 months ago (2014-04-29 19:38:41 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 04:47:26 UTC) #16
Message was sent while issue was closed. 
Change committed as 172928

Powered by Google App Engine
This is Rietveld 408576698