Fix registration of closure functions

runtime/vm/flow_graph_builder.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_builder.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/ast_printer.h"
 #include "vm/bit_vector.h"
 #include "vm/class_finalizer.h"
@@ skipping 2174 matching lines @@
   if (function.context_scope() == ContextScope::null()) {
     ASSERT(!is_implicit);
     const ContextScope& context_scope = ContextScope::ZoneHandle(
         node->scope()->PreserveOuterScope(owner()->context_level()));
     ASSERT(!function.HasCode());
     ASSERT(function.context_scope() == ContextScope::null());
     function.set_context_scope(context_scope);
     const Class& cls = Class::Handle(
         owner()->parsed_function()->function().Owner());
     // The closure is now properly setup, add it to the lookup table.
-#if DEBUG
+    // It is possible that the compiler creates more than one function
+    // object for the same closure, e.g. when inlining nodes from
+    // finally clauses. If we already have a function object for the
+    // same closure, do not add a second one. We compare the origin
+    // class, token position, and parent function to detect duplicates.
+    // Note that we can have two different closure object for the same
+    // source text represntation of the closure: one with a non-closurized
+    // parent, and one with a closurized parent function.
+
     const Function& found_func = Function::Handle(
         cls.LookupClosureFunction(function.token_pos()));
-    ASSERT(found_func.IsNull() ||
-           (found_func.token_pos() != function.token_pos()) ||
-           // TODO(hausner): The following check should not be necessary.
-           // Since we only lookup based on the token_pos we can get
-           // duplicate entries due to closurized and non-closurized parent
-           // functions (see Parser::ParseFunctionStatement).
-           // We need two ways to lookup in this cache: One way to cache the
-           // appropriate closure function and one way to find the functions
-           // while debugging (we might need to set breakpoints in multiple
-           // different function for a single token index.)
-           (found_func.parent_function() != function.parent_function()));
-#endif  // DEBUG
-    cls.AddClosureFunction(function);
+
+    if (found_func.IsNull() ||
+        (found_func.token_pos() != function.token_pos()) ||
+        (found_func.script() != function.script()) ||
+        (found_func.parent_function() != function.parent_function())) {
+      cls.AddClosureFunction(function);
+    }
   }
   ZoneGrowableArray<PushArgumentInstr*>* arguments =
       new ZoneGrowableArray<PushArgumentInstr*>(1);
   ASSERT(function.context_scope() != ContextScope::null());
 
   // The function type of a closure may have type arguments. In that case,
   // pass the type arguments of the instantiator.
   const Class& cls = Class::ZoneHandle(function.signature_class());
   ASSERT(!cls.IsNull());
   const bool requires_type_arguments = cls.NumTypeArguments() > 0;
@@ skipping 1635 matching lines @@
                                   function.token_pos(),
                                   LanguageError::kError,
                                   Heap::kNew,
                                   "FlowGraphBuilder Bailout: %s %s",
                                   String::Handle(function.name()).ToCString(),
                                   reason));
   Isolate::Current()->long_jump_base()->Jump(1, error);
 }
 
 }  // namespace dart