Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2528923002: Revert of Remove requisition parameter for Chromad. (Closed)

Created:
4 years ago by Roman Sorokin (ftl)
Modified:
4 years ago
Reviewers:
Thiemo Nagel
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove requisition parameter for Chromad. (patchset #1 id:20001 of https://codereview.chromium.org/2476243002/ ) Reason for revert: Reverting this cause server side was fixed and now works good. Original issue's description: > Remove requisition parameter for Chromad. > > The server returns an error when the chrome_ad requisition parameter is set, > thus removing it to unblock testing and further work. > > BUG=639066 > > Committed: https://crrev.com/f77f4925ac2b43590677b5cfdce55ce161de48a1 > Cr-Commit-Position: refs/heads/master@{#430255} TBR=tnagel@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=639066 Committed: https://crrev.com/81b609d9c117d7d34a5f542d0306873eb6b1db5e Cr-Commit-Position: refs/heads/master@{#434344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Roman Sorokin (ftl)
Created Revert of Remove requisition parameter for Chromad.
4 years ago (2016-11-24 13:23:18 UTC) #1
Roman Sorokin (ftl)
Thiemo, PTAL
4 years ago (2016-11-24 13:23:59 UTC) #2
Thiemo Nagel
LGTM
4 years ago (2016-11-24 14:19:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528923002/1
4 years ago (2016-11-24 14:20:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/279273)
4 years ago (2016-11-24 15:39:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528923002/1
4 years ago (2016-11-24 16:07:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 16:35:40 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-24 16:38:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81b609d9c117d7d34a5f542d0306873eb6b1db5e
Cr-Commit-Position: refs/heads/master@{#434344}

Powered by Google App Engine
This is Rietveld 408576698