[compiler] Make --debug-code the default in debug builds.

[compiler] Make --debug-code the default in debug builds.

This enables {FLAG_debug_code} by default in debug builds. The advantage
is that generated code contained within the snapshot will contain such
debug code. Before we would only get coverage for these pieces with the
no-snapshot builds, which have a meager coverage. One can still pass the
inverse --no-debug-code flag to ensure generated code remains readable
within debug builds as well.

R=machenbach@chromium.org

Committed: https://crrev.com/651c1b86a2757475ba0332b06f149ec3c0347ef0
Cr-Commit-Position: refs/heads/master@{#41451}

[Michael Starzinger, 2016-11-24 12:45:12]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 12:45:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 13:07:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 13:07:12]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/16806)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[Michael Starzinger, 2016-12-02 10:07:32]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 10:07:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 10:28:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 10:28:31]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/17217)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[Michael Starzinger, 2016-12-02 10:37:05]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 10:37:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 11:01:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 11:01:07]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-12-02 11:25:31]

Description was changed from

==========
[compiler] Make --debug-code the default in debug builds.

This enables {FLAG_debug_code} by default in debug builds. The advantage
is that generated code contained within the snapshot will contain such
debug code. Before we would only get coverage for these pieces with the
no-snapshot builds, which have a meager coverage. One can still pass the
inverse --no-debug-code flag to ensure generated code remains readable
within debug builds as well.

R=
==========

to

==========
[compiler] Make --debug-code the default in debug builds.

This enables {FLAG_debug_code} by default in debug builds. The advantage
is that generated code contained within the snapshot will contain such
debug code. Before we would only get coverage for these pieces with the
no-snapshot builds, which have a meager coverage. One can still pass the
inverse --no-debug-code flag to ensure generated code remains readable
within debug builds as well.

R=machenbach@chromium.org
==========

[Michael Starzinger, 2016-12-02 11:25:31]

mstarzinger@chromium.org changed reviewers:
+ bmeurer@chromium.org, machenbach@chromium.org

[Benedikt Meurer, 2016-12-02 11:31:41]

LGTM. I like it, thanks.

[Michael Achenbach, 2016-12-02 11:32:21]

lgtm

[Michael Starzinger, 2016-12-02 11:34:47]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-12-02 11:34:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 11:36:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480678487425590,
"parent_rev": "0b8adaaadfe7e3a8e7d2c23284a918e81bcbcacd", "commit_rev":
"a246d1d02a67715a27c059b3ea33e534b062351e"}

[commit-bot: I haz the power, 2016-12-02 11:36:42]

Description was changed from

==========
[compiler] Make --debug-code the default in debug builds.

This enables {FLAG_debug_code} by default in debug builds. The advantage
is that generated code contained within the snapshot will contain such
debug code. Before we would only get coverage for these pieces with the
no-snapshot builds, which have a meager coverage. One can still pass the
inverse --no-debug-code flag to ensure generated code remains readable
within debug builds as well.

R=machenbach@chromium.org
==========

to

==========
[compiler] Make --debug-code the default in debug builds.

This enables {FLAG_debug_code} by default in debug builds. The advantage
is that generated code contained within the snapshot will contain such
debug code. Before we would only get coverage for these pieces with the
no-snapshot builds, which have a meager coverage. One can still pass the
inverse --no-debug-code flag to ensure generated code remains readable
within debug builds as well.

R=machenbach@chromium.org
==========

[commit-bot: I haz the power, 2016-12-02 11:36:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-02 11:37:08]

Description was changed from

==========
[compiler] Make --debug-code the default in debug builds.

This enables {FLAG_debug_code} by default in debug builds. The advantage
is that generated code contained within the snapshot will contain such
debug code. Before we would only get coverage for these pieces with the
no-snapshot builds, which have a meager coverage. One can still pass the
inverse --no-debug-code flag to ensure generated code remains readable
within debug builds as well.

R=machenbach@chromium.org
==========

to

==========
[compiler] Make --debug-code the default in debug builds.

This enables {FLAG_debug_code} by default in debug builds. The advantage
is that generated code contained within the snapshot will contain such
debug code. Before we would only get coverage for these pieces with the
no-snapshot builds, which have a meager coverage. One can still pass the
inverse --no-debug-code flag to ensure generated code remains readable
within debug builds as well.

R=machenbach@chromium.org

Committed: https://crrev.com/651c1b86a2757475ba0332b06f149ec3c0347ef0
Cr-Commit-Position: refs/heads/master@{#41451}
==========

[commit-bot: I haz the power, 2016-12-02 11:37:10]

Patchset 3 (id:??) landed as
https://crrev.com/651c1b86a2757475ba0332b06f149ec3c0347ef0
Cr-Commit-Position: refs/heads/master@{#41451}

[neis, 2016-12-02 11:49:35]

Nice!