Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2528903002: Allow the PDF extension for chrome://print pages. (Closed)

Created:
4 years ago by Mike West
Modified:
4 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow the PDF extension for chrome://print pages. We have an experiment running that would disable parser-inserted usage of 'chrome-extension://' URLs unless explicitly whitelisted. This breaks the print preview page, which relies on the PDF extension URLs inside an HTML import. So. This patch adds a mechanism for whitelisting that extension URL for the print preview page. BUG=667224 R=tsepez@chromium.org Committed: https://crrev.com/c5dd67fc5244bc8ee3fa74bea9835a0d054d2a37 Cr-Commit-Position: refs/heads/master@{#434770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/webui/web_ui_data_source_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/webui/web_ui_data_source_impl.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M content/public/browser/web_ui_data_source.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Mike West
WDYT, Tom?
4 years ago (2016-11-24 12:29:34 UTC) #1
Mike West
Jochen, perhaps you could stamp this, on the off chance that Tom approves it overnight? ...
4 years ago (2016-11-28 15:36:23 UTC) #7
jochen (gone - plz use gerrit)
stampety-stamp lgtm
4 years ago (2016-11-28 15:37:19 UTC) #9
Tom Sepez
lgtm
4 years ago (2016-11-28 17:13:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528903002/1
4 years ago (2016-11-28 21:04:18 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 23:26:00 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-28 23:29:52 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5dd67fc5244bc8ee3fa74bea9835a0d054d2a37
Cr-Commit-Position: refs/heads/master@{#434770}

Powered by Google App Engine
This is Rietveld 408576698