Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2528893003: [PhysicalWeb] Add physical_web namespace. (Closed)

Created:
4 years ago by vitaliii
Modified:
4 years ago
CC:
chromium-reviews, James Su, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[PhysicalWeb] Add physical_web namespace. TBR=pkasting,thakis BUG=None Committed: https://crrev.com/ee92054e99fa62d7d1a5e6299753215e9fb940b6 Cr-Commit-Position: refs/heads/master@{#434506}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -64 lines) Patch
M chrome/browser/android/physical_web/physical_web_data_source_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/physical_web/physical_web_data_source_android.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/autocomplete/chrome_autocomplete_provider_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/autocomplete_provider_client.h View 3 chunks +5 lines, -2 lines 0 comments Download
M components/omnibox/browser/mock_autocomplete_provider_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/physical_web_provider.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/omnibox/browser/physical_web_provider_unittest.cc View 6 chunks +15 lines, -11 lines 1 comment Download
M components/physical_web/data_source/physical_web_data_source.h View 2 chunks +12 lines, -8 lines 0 comments Download
M components/physical_web/data_source/physical_web_data_source.cc View 1 chunk +12 lines, -8 lines 0 comments Download
M components/physical_web/data_source/physical_web_data_source_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/physical_web/data_source/physical_web_data_source_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/physical_web/data_source/physical_web_data_source_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/physical_web/data_source/physical_web_listener.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/application_context.h View 3 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/application_context_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/common/physical_web/physical_web_scanner.mm View 1 chunk +5 lines, -5 lines 0 comments Download
M ios/chrome/test/testing_application_context.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/testing_application_context.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 49 (41 generated)
vitaliii
Hi Olivier, Could you please have a look at my CL? Feel free to postpone ...
4 years ago (2016-11-25 11:57:02 UTC) #33
Olivier
LGTM
4 years ago (2016-11-25 13:52:36 UTC) #36
vitaliii
Hi droger@, Would you mind having a look at ios/ change?
4 years ago (2016-11-25 13:59:54 UTC) #38
vitaliii
Hi miguelg, Could you have a look at chrome/browser/android/ change? Olivier (PhysicalWeb owner) has given ...
4 years ago (2016-11-25 14:06:27 UTC) #40
droger
LGTM I think this kind of changes can be TBR'ed in general (that is simply ...
4 years ago (2016-11-25 15:02:56 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528893003/130001
4 years ago (2016-11-25 15:16:11 UTC) #44
commit-bot: I haz the power
Committed patchset #1 (id:130001)
4 years ago (2016-11-25 15:21:01 UTC) #47
commit-bot: I haz the power
4 years ago (2016-11-25 15:23:28 UTC) #49
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee92054e99fa62d7d1a5e6299753215e9fb940b6
Cr-Commit-Position: refs/heads/master@{#434506}

Powered by Google App Engine
This is Rietveld 408576698