Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2528883003: Reland of [stubs] KeyedStoreGeneric: inline dictionary property stores (Closed)

Created:
4 years ago by Jakob Kummerow
Modified:
4 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland^2 of [stubs] KeyedStoreGeneric: inline dictionary property stores For dictionary-mode receivers, the KeyedStoreGeneric stub can store properties directly in most cases. Doing so avoids the need to have an entry in the stub cache for every map/property combination. Original review: https://codereview.chromium.org/2504403005/ Committed: https://crrev.com/9be747666ca0eb6b9fad81425c311d76b405e27a Cr-Commit-Position: refs/heads/master@{#41272}

Patch Set 1 #

Patch Set 2 : fix AccessorInfo mixup (issue 2525913002) #

Patch Set 3 : fix for deleted-elements issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+592 lines, -84 lines) Patch
M src/builtins/builtins-array.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/code-stub-assembler.h View 1 2 4 chunks +58 lines, -20 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 12 chunks +186 lines, -18 lines 0 comments Download
M src/code-stubs.cc View 1 2 chunks +11 lines, -13 lines 0 comments Download
M src/ic/accessor-assembler.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/ic/keyed-store-generic.cc View 1 5 chunks +254 lines, -20 lines 0 comments Download
M src/objects.h View 1 2 chunks +6 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-668101.js View 1 1 chunk +21 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-private-enumerable.js View 1 1 chunk +23 lines, -0 lines 0 comments Download
M test/mjsunit/store-dictionary.js View 1 2 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Jakob Kummerow
Created Reland of [stubs] KeyedStoreGeneric: inline dictionary property stores
4 years ago (2016-11-24 14:52:41 UTC) #1
Jakob Kummerow
PTAL. The diff from patch set 1 -> 2 is the only change you haven't ...
4 years ago (2016-11-24 15:17:21 UTC) #4
Igor Sheludko
lgtm
4 years ago (2016-11-24 15:24:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528883003/210001
4 years ago (2016-11-24 16:20:58 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:210001)
4 years ago (2016-11-24 16:22:58 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-24 16:23:19 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9be747666ca0eb6b9fad81425c311d76b405e27a
Cr-Commit-Position: refs/heads/master@{#41272}

Powered by Google App Engine
This is Rietveld 408576698