Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2528853003: [turbofan] Infer proper type for calls to Date.now. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Infer proper type for calls to Date.now. Recognize Date.now() calls in the Typer and assign the proper integer type to them. See Node issue https://github.com/nodejs/node/issues/9729 for more information. R=yangguo@chromium.org BUG=v8:5267 Committed: https://crrev.com/3709108896ce840b0e3131710bf667f68637a8e7 Cr-Commit-Position: refs/heads/master@{#41242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M src/compiler/type-cache.h View 2 chunks +7 lines, -3 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Benedikt Meurer
4 years ago (2016-11-24 06:13:02 UTC) #1
Yang
On 2016/11/24 06:13:02, Benedikt Meurer wrote: lgtm.
4 years ago (2016-11-24 06:17:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528853003/1
4 years ago (2016-11-24 06:18:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 06:41:31 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-24 06:41:51 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3709108896ce840b0e3131710bf667f68637a8e7
Cr-Commit-Position: refs/heads/master@{#41242}

Powered by Google App Engine
This is Rietveld 408576698