[Cronet] Test via API not by manually constructing impl

[Cronet] Test via API not by manually constructing impl

There's no reason to construct impl directly via
"new CronetUrlRequestContext"; instead test via the
public API (i.e. "new CronetEngine.Builder").

R=kapishnikov
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/897a07a1f63167c49a17ab7ae79d8ea8224ef78e
Cr-Commit-Position: refs/heads/master@{#434656}

[pauljensen, 2016-11-24 02:25:40]

Description was changed from

==========
[Cronet] Test via API not by manually constructing impl

R=kapishnikov
==========

to

==========
[Cronet] Test via API not by manually constructing impl

R=kapishnikov
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[pauljensen, 2016-11-24 02:53:22]

Description was changed from

==========
[Cronet] Test via API not by manually constructing impl

R=kapishnikov
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Test via API not by manually constructing impl

There's no reason to construct impl directly via
"new CronetUrlRequestContext"; instead test via the
public API (i.e. "new CronetEngine.Builder").

R=kapishnikov
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[pauljensen, 2016-11-24 02:53:56]

pauljensen@chromium.org changed reviewers:
+ xunjieli@chromium.org
- kapishnikov@chromium.org

[pauljensen, 2016-11-24 02:53:57]

Helen, PTAL, thank you!

[xunjieli, 2016-11-28 00:30:53]

https://codereview.chromium.org/2528833002/diff/1/components/cronet/android/t...
File
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
(right):

https://codereview.chromium.org/2528833002/diff/1/components/cronet/android/t...
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java:549:
new ExperimentalCronetEngine.Builder(context).build();
Is there a reason that these are explicitly ExperimentalCronetEngine.Builder?
I noticed that there are two places where you used CronetEngine.Builder
(testInitDifferentEngines and testNetLogWithBytes). 
Can we use CronetEngine.Builder for all of them?

[pauljensen, 2016-11-28 12:56:44]

https://codereview.chromium.org/2528833002/diff/1/components/cronet/android/t...
File
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
(right):

https://codereview.chromium.org/2528833002/diff/1/components/cronet/android/t...
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java:549:
new ExperimentalCronetEngine.Builder(context).build();
On 2016/11/28 00:30:53, xunjieli wrote:
> Is there a reason that these are explicitly ExperimentalCronetEngine.Builder?
> I noticed that there are two places where you used CronetEngine.Builder
> (testInitDifferentEngines and testNetLogWithBytes). 
> Can we use CronetEngine.Builder for all of them?

Some of the tests use startNetLogToDisk which is experimental.  I switched the
ones I could to CronetEngine.

[xunjieli, 2016-11-28 14:22:58]

Great. LGTM Thanks!

[pauljensen, 2016-11-28 14:23:46]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2016-11-28 14:24:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 14:51:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480343026859980,
"parent_rev": "29894dc970be23c192da142fdda435523a1a1605", "commit_rev":
"6aefea63d16dff3df4315e73b9382fe42b9740d6"}

[commit-bot: I haz the power, 2016-11-28 14:52:03]

Description was changed from

==========
[Cronet] Test via API not by manually constructing impl

There's no reason to construct impl directly via
"new CronetUrlRequestContext"; instead test via the
public API (i.e. "new CronetEngine.Builder").

R=kapishnikov
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Test via API not by manually constructing impl

There's no reason to construct impl directly via
"new CronetUrlRequestContext"; instead test via the
public API (i.e. "new CronetEngine.Builder").

R=kapishnikov
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[commit-bot: I haz the power, 2016-11-28 14:52:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-28 14:53:48]

Description was changed from

==========
[Cronet] Test via API not by manually constructing impl

There's no reason to construct impl directly via
"new CronetUrlRequestContext"; instead test via the
public API (i.e. "new CronetEngine.Builder").

R=kapishnikov
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Test via API not by manually constructing impl

There's no reason to construct impl directly via
"new CronetUrlRequestContext"; instead test via the
public API (i.e. "new CronetEngine.Builder").

R=kapishnikov
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/897a07a1f63167c49a17ab7ae79d8ea8224ef78e
Cr-Commit-Position: refs/heads/master@{#434656}
==========

[commit-bot: I haz the power, 2016-11-28 14:53:49]

Patchset 2 (id:??) landed as
https://crrev.com/897a07a1f63167c49a17ab7ae79d8ea8224ef78e
Cr-Commit-Position: refs/heads/master@{#434656}