Separate SwipeRefreshHandler and ContentViewCore

content/browser/renderer_host/render_widget_host_view_android.h

Index: content/browser/renderer_host/render_widget_host_view_android.h
diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h
index 0ac77152c1d894993b73fedd962a885adfcb6620..1b2b868b785576309100db9c841a838fa23a6fbc 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.h
+++ b/content/browser/renderer_host/render_widget_host_view_android.h
@@ -30,6 +30,7 @@
 #include "content/public/browser/readback_types.h"
 #include "gpu/command_buffer/common/mailbox.h"
 #include "third_party/skia/include/core/SkColor.h"
+#include "ui/android/overscroll_refresh.h"
 #include "ui/android/view_android.h"
 #include "ui/android/window_android_observer.h"
 #include "ui/events/android/motion_event_android.h"
@@ -79,8 +80,10 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
       public ui::TouchSelectionControllerClient,
       public content::ContentViewCoreImplObserver {
  public:
-  RenderWidgetHostViewAndroid(RenderWidgetHostImpl* widget,
-                              ContentViewCoreImpl* content_view_core);
+  RenderWidgetHostViewAndroid(
+      RenderWidgetHostImpl* widget,
+      ContentViewCoreImpl* content_view_core,
+      ui::OverscrollRefreshHandler* overscroll_refresh_handler);

[Jinsuk Kim, 2016/11/25 01:49:18]

Consider adding a setter instead as this is an optional parameter used for a
certain embedder, like SynchronousCompositorClient. 

[rlanday, 2016/11/28 21:17:51]

I'm not sure how much I like that, because if this is passed into the
constructor, that's only one place allowable to set this that we have to be
concerned with, whereas if we have a setter, we either have to worry about stuff
like what if the caller screws up and tries to set the OverscrollRefreshHandler
after we've already constructed the OverscrollController, or tries to set the
handle again after it's already set. If we end up needing this functionality for
some reason we can add a setter, otherwise I think it probably just makes stuff
messier.

[Jinsuk Kim, 2016/11/28 23:06:40]

We wouldn't want to keep adding parameters to the constructor but you have a
point.

   ~RenderWidgetHostViewAndroid() override;
 
   void Blur();
@@ -319,6 +322,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
   // ContentViewCoreImpl is our interface to the view system.
   ContentViewCoreImpl* content_view_core_;
 
+  ui::OverscrollRefreshHandler* overscroll_refresh_handler_;
+
   ImeAdapterAndroid ime_adapter_android_;
 
   // Body background color of the underlying document.