chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java - Issue 2528823002: Separate SwipeRefreshHandler and ContentViewCore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2528823002: Separate SwipeRefreshHandler and ContentViewCore (Closed)

Patch Set: Fix compile error in test case Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

index d66c51042af0e6e5656f349585d95fce9f7c7139..a11a115808cbeae2ed2fa121465643334c7e2e69 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

@@ -1782,6 +1782,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

mInfoBarContainer.setContentViewCore(mContentViewCore);

mSwipeRefreshHandler = new SwipeRefreshHandler(mThemedApplicationContext, this);

+ mContentViewCore.getWebContents().setOverscrollRefreshHandler(mSwipeRefreshHandler);

Ted C 2016/11/29 00:06:08 any reason to not do that inside of the constructo

rlanday 2016/11/29 00:46:25 I think this is a good suggestion; @jinsukkim is s

rlanday 2016/11/29 00:46:25 I think this is a good suggestion, I believe it wi

updateThemeColorIfNeeded(false);

notifyContentChanged();