chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java - Issue 2528823002: Separate SwipeRefreshHandler and ContentViewCore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2528823002: Separate SwipeRefreshHandler and ContentViewCore (Closed)

Patch Set: Respond to boliu's comments, refactor CreateOverscrollController() function Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

index d1d9bcc0a6b43c13fc04fef344e081d4db04f7ef..0a0d398e85cfb64be3ea903a850114faaa054f66 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

@@ -1795,7 +1795,8 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

}

mInfoBarContainer.setContentViewCore(mContentViewCore);

- mSwipeRefreshHandler = new SwipeRefreshHandler(mThemedApplicationContext, this);

+ mSwipeRefreshHandler = new SwipeRefreshHandler(

+ mThemedApplicationContext, this, mContentViewCore.getWebContents());

updateThemeColorIfNeeded(false);

notifyContentChanged();