Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1487)

Unified Diff: content/browser/android/overscroll_controller_android.h

Issue 2528823002: Separate SwipeRefreshHandler and ContentViewCore (Closed)
Patch Set: Make boliu's requested changes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/overscroll_controller_android.h
diff --git a/content/browser/android/overscroll_controller_android.h b/content/browser/android/overscroll_controller_android.h
index 199256c4fd62da39f9be8cd4bb916113d25519a8..3566a91ea28effd2ce8fd26ed563fa7af7a3156b 100644
--- a/content/browser/android/overscroll_controller_android.h
+++ b/content/browser/android/overscroll_controller_android.h
@@ -7,11 +7,13 @@
#include <memory>
+#include "base/android/scoped_java_ref.h"
#include "base/macros.h"
#include "base/time/time.h"
#include "content/common/input/input_event_ack_state.h"
#include "ui/android/overscroll_glow.h"
#include "ui/android/overscroll_refresh.h"
+#include "ui/android/overscroll_refresh_handler.h"
boliu 2016/12/06 00:58:16 I think forward declare this in header and then in
rlanday 2016/12/06 03:25:26 Yep
#include "ui/gfx/geometry/vector2d_f.h"
namespace blink {
@@ -30,15 +32,15 @@ struct DidOverscrollParams;
namespace content {
-class ContentViewCoreImpl;
-
// Glue class for handling all inputs into Android-specific overscroll effects,
// both the passive overscroll glow and the active overscroll pull-to-refresh.
// Note that all input coordinates (both for events and overscroll) are in DIPs.
class OverscrollControllerAndroid : public ui::OverscrollGlowClient {
public:
- explicit OverscrollControllerAndroid(ContentViewCoreImpl* content_view_core,
- float dpi_scale);
+ OverscrollControllerAndroid(
+ ui::OverscrollRefreshHandler* overscroll_refresh_handler,
+ ui::WindowAndroidCompositor* compositor,
+ float dpi_scale);
~OverscrollControllerAndroid() override;
// Returns true if |event| is consumed by an overscroll effect, in which

Powered by Google App Engine
This is Rietveld 408576698