Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 2528823002: Separate SwipeRefreshHandler and ContentViewCore (Closed)
Patch Set: Make boliu's requested changes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index 93e95b3df5aeba29952e178285429f7779b183de..2e17d39882315bf326711a58d99dceb5cb6d5089 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -1546,36 +1546,6 @@ void ContentViewCoreImpl::WebContentsDestroyed() {
wcva->SetContentViewCore(NULL);
}
-bool ContentViewCoreImpl::PullStart() {
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
- if (!obj.is_null())
- return Java_ContentViewCore_onOverscrollRefreshStart(env, obj);
- return false;
-}
-
-void ContentViewCoreImpl::PullUpdate(float delta) {
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
- if (!obj.is_null())
- Java_ContentViewCore_onOverscrollRefreshUpdate(env, obj, delta);
-}
-
-void ContentViewCoreImpl::PullRelease(bool allow_refresh) {
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
- if (!obj.is_null()) {
- Java_ContentViewCore_onOverscrollRefreshRelease(env, obj, allow_refresh);
- }
-}
-
-void ContentViewCoreImpl::PullReset() {
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
- if (!obj.is_null())
- Java_ContentViewCore_onOverscrollRefreshReset(env, obj);
-}
-
// This is called for each ContentView.
jlong Init(JNIEnv* env,
const JavaParamRef<jobject>& obj,

Powered by Google App Engine
This is Rietveld 408576698