Separate SwipeRefreshHandler and ContentViewCore

content/browser/web_contents/web_contents_view_android.h

Index: content/browser/web_contents/web_contents_view_android.h
diff --git a/content/browser/web_contents/web_contents_view_android.h b/content/browser/web_contents/web_contents_view_android.h
index 1a5ec57e6e4889779f3dfeaffc2d8c17240ba8b6..11a505ed83f8370182f025ef4c8edf8ef190701f 100644
--- a/content/browser/web_contents/web_contents_view_android.h
+++ b/content/browser/web_contents/web_contents_view_android.h
@@ -13,6 +13,7 @@
 #include "content/public/browser/web_contents_view_delegate.h"
 #include "content/public/common/context_menu_params.h"
 #include "content/public/common/drop_data.h"
+#include "ui/android/overscroll_refresh.h"
 #include "ui/android/view_android.h"
 #include "ui/gfx/geometry/rect_f.h"
 
@@ -43,6 +44,11 @@ class WebContentsViewAndroid : public WebContentsView,
     return synchronous_compositor_client_;
   }
 
+  void SetOverscrollRefreshHandler(

[boliu, 2016/12/01 00:01:57]

this should not be inlined

also what if RWHVA is already created when this is called?

[rlanday, 2016/12/01 00:44:51]

Yeah this is kind of sloppy...what's a good way to do this? I can think of a
couple options, none of which seem great:
1. Enforce via invariant that this method can't be called after the RWHVA is
constructed
2. Add a bunch of code that may never get used to support switching out the
RenderWidgetHostViewAndroid's OverscrollRefreshHandler?
3. Allow calling the method but just not do anything with the
OverscrollRefreshHandler? (the way it currently works)

I don't think passing it in the WebContentsViewAndroid constructor really works
unless we have it all the way back in WebContents::CreateParams when we create
the WebContents object, which I suspect will not work

[boliu, 2016/12/01 00:50:38]

RWHVA can be created before WCVA, ie popups
This looks like the only option.

+      const base::android::JavaParamRef<jobject>& overscroll_refresh_handler) {
+    overscroll_refresh_handler_.Reset(nullptr, overscroll_refresh_handler);
+  }
+
   // WebContentsView implementation --------------------------------------------
   gfx::NativeView GetNativeView() const override;
   gfx::NativeView GetContentNativeView() const override;
@@ -108,6 +114,9 @@ class WebContentsViewAndroid : public WebContentsView,
   // ContentViewCoreImpl is our interface to the view system.
   ContentViewCoreImpl* content_view_core_;
 
+  // Handles "overscroll to refresh" events
+  base::android::ScopedJavaGlobalRef<jobject> overscroll_refresh_handler_;
+
   // Interface for extensions to WebContentsView. Used to show the context menu.
   std::unique_ptr<WebContentsViewDelegate> delegate_;