third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp - Issue 2528813002: Fix Self-Referencing OOPIF Infinite Loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp

Issue 2528813002: Fix Self-Referencing OOPIF Infinite Loop (Closed)

Patch Set: refactor allowedToLoadFrame conditional Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp b/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp

index e4220b0b5b1494729f2daa86f1eb9b9e50c45ba1..88be6698d689f437bdd3657d96da553c12d95759 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp

@@ -71,11 +71,6 @@ bool HTMLFrameElementBase::isURLAllowed() const {

BindingSecurity::ErrorReportOption::Report))

return false;

}

- LocalFrame* parentFrame = document().frame();

- if (parentFrame)

- return parentFrame->isURLAllowed(completeURL);

return true;

}