Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2528813002: Fix Self-Referencing OOPIF Infinite Loop (Closed)
Patch Set: actually fix broken test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
index 1d711cb31da6bb8da232d4b21a31b29fb9ba14e7..b938580b8a5bbd1814356ae40a07d61f91052d3d 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
@@ -810,27 +810,6 @@ EphemeralRange LocalFrame::rangeForPoint(const IntPoint& framePoint) {
return EphemeralRange();
}
-bool LocalFrame::isURLAllowed(const KURL& url) const {
- // Exempt about: URLs from self-reference check.
- if (url.protocolIsAbout())
- return true;
-
- // We allow one level of self-reference because some sites depend on that,
- // but we don't allow more than one.
- bool foundSelfReference = false;
- for (const Frame* frame = this; frame; frame = frame->tree().parent()) {
- if (!frame->isLocalFrame())
- continue;
- if (equalIgnoringFragmentIdentifier(toLocalFrame(frame)->document()->url(),
- url)) {
- if (foundSelfReference)
- return false;
- foundSelfReference = true;
- }
- }
- return true;
-}
-
bool LocalFrame::shouldReuseDefaultView(const KURL& url) const {
// Secure transitions can only happen when navigating from the initial empty
// document.

Powered by Google App Engine
This is Rietveld 408576698