Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 2528813002: Fix Self-Referencing OOPIF Infinite Loop (Closed)
Patch Set: Add |state_| change in |WillStartRequest| and |WillRedirectRequest| Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index 20a159af380b79c8a118d88c4fd31c9f2f599a1d..06a74ff654ed2ba5ce3ec4640238b7108ee3e450 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -346,6 +346,11 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
// Populates |throttles_| with the throttles for this navigation.
void RegisterNavigationThrottles();
+ // Checks for attempts to navigate to a page that is already referenced more
+ // than once in its ancestors. This is a helper function used by
alexmos 2017/01/06 02:27:29 nit: s/its/the frame's/
davidsac (gone - try alexmos) 2017/01/19 18:26:23 Done.
+ // WillStartRequest and WillRedirectRequest to prevent the navigation.
+ bool IsSelfReferentialURL();
+
// See NavigationHandle for a description of those member variables.
GURL url_;
scoped_refptr<SiteInstance> starting_site_instance_;

Powered by Google App Engine
This is Rietveld 408576698