third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp - Issue 2528813002: Fix Self-Referencing OOPIF Infinite Loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 2528813002: Fix Self-Referencing OOPIF Infinite Loop (Closed)

Patch Set: add fix to find and renderframe tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

index 60960f26f49e1622bcd11ceda71c90c85bbf567e..8c0538db0ae3b5355c727f7e96abc0149215fabb 100644

--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

@@ -469,7 +469,7 @@ bool HTMLPlugInElement::allowedToLoadFrameURL(const String& url) {

!document().getSecurityOrigin()->canAccess(

contentFrame()->securityContext()->getSecurityOrigin()))

return false;

- return document().frame()->isURLAllowed(completeURL);

+ return true;

}

// We don't use m_url, or m_serviceType as they may not be the final values