Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(79)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: content/test/data/coreferencingframe_2.html
Issue
2528813002
:
Fix Self-Referencing OOPIF Infinite Loop (Closed)
Patch Set: refactor allowedToLoadFrame conditional
Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
content/browser/frame_host/navigation_handle_impl.h
content/browser/frame_host/navigation_handle_impl.cc
content/browser/frame_host/render_frame_host_manager_browsertest.cc
content/test/data/coreferencingframe_1.html
content/test/data/coreferencingframe_2.html
content/test/data/page_with_meta_refresh_frame.html
third_party/WebKit/Source/core/frame/LocalFrame.h
third_party/WebKit/Source/core/frame/LocalFrame.cpp
third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp
third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« content/test/data/coreferencingframe_1.html
('k') |
content/test/data/page_with_meta_refresh_frame.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<html>
3
<body>
4
B - This page has co-referencing nested iframes.
5
<iframe id="child-0" src="/cross-site/a.com/coreferencingframe_1.html"></ifram e>
6
</body>
7
</html>
OLD
NEW
« no previous file with comments
|
« content/test/data/coreferencingframe_1.html
('k') |
content/test/data/page_with_meta_refresh_frame.html »
('j') |
no next file with comments »
Issue 2528813002: Fix Self-Referencing OOPIF Infinite Loop (Closed)
Created 4 years ago by davidsac (gone - try alexmos)
Modified 3 years, 10 months ago
Reviewers: alexmos, nasko, dcheng
Base URL:
Comments: 130
This is Rietveld
408576698
Chromium Code Reviews
Issue 2528813002:
Fix Self-Referencing OOPIF Infinite Loop (Closed)
