Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 2528813002: Fix Self-Referencing OOPIF Infinite Loop (Closed)
Patch Set: refactor allowedToLoadFrame conditional Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_handle_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
7 7
8 #include "content/public/browser/navigation_handle.h" 8 #include "content/public/browser/navigation_handle.h"
9 9
10 #include <stddef.h> 10 #include <stddef.h>
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 // Helper function to run and reset the |complete_callback_|. This marks the 373 // Helper function to run and reset the |complete_callback_|. This marks the
374 // end of a round of NavigationThrottleChecks. 374 // end of a round of NavigationThrottleChecks.
375 void RunCompleteCallback(NavigationThrottle::ThrottleCheckResult result); 375 void RunCompleteCallback(NavigationThrottle::ThrottleCheckResult result);
376 376
377 // Used in tests. 377 // Used in tests.
378 State state() const { return state_; } 378 State state() const { return state_; }
379 379
380 // Populates |throttles_| with the throttles for this navigation. 380 // Populates |throttles_| with the throttles for this navigation.
381 void RegisterNavigationThrottles(); 381 void RegisterNavigationThrottles();
382 382
383 // Checks for attempts to navigate to a page that is already referenced more
384 // than once in the frame's ancestors. This is a helper function used by
385 // WillStartRequest and WillRedirectRequest to prevent the navigation.
386 bool IsSelfReferentialURL();
387
383 // See NavigationHandle for a description of those member variables. 388 // See NavigationHandle for a description of those member variables.
384 GURL url_; 389 GURL url_;
385 scoped_refptr<SiteInstance> starting_site_instance_; 390 scoped_refptr<SiteInstance> starting_site_instance_;
386 Referrer sanitized_referrer_; 391 Referrer sanitized_referrer_;
387 bool has_user_gesture_; 392 bool has_user_gesture_;
388 ui::PageTransition transition_; 393 ui::PageTransition transition_;
389 bool is_external_protocol_; 394 bool is_external_protocol_;
390 net::Error net_error_code_; 395 net::Error net_error_code_;
391 RenderFrameHostImpl* render_frame_host_; 396 RenderFrameHostImpl* render_frame_host_;
392 const bool is_renderer_initiated_; 397 const bool is_renderer_initiated_;
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
491 NavigationType navigation_type_; 496 NavigationType navigation_type_;
492 497
493 base::WeakPtrFactory<NavigationHandleImpl> weak_factory_; 498 base::WeakPtrFactory<NavigationHandleImpl> weak_factory_;
494 499
495 DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl); 500 DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl);
496 }; 501 };
497 502
498 } // namespace content 503 } // namespace content
499 504
500 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_ 505 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_handle_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698