Fix Self-Referencing OOPIF Infinite Loop

third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

 /**
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Stefan Schimanski (1Stein@gmx.de)
  * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 451 matching lines @@
 }
 
 // We don't use m_url, as it may not be the final URL that the object loads,
 // depending on <param> values.
 bool HTMLPlugInElement::allowedToLoadFrameURL(const String& url) {
   KURL completeURL = document().completeURL(url);
   if (contentFrame() && completeURL.protocolIsJavaScript() &&
       !document().getSecurityOrigin()->canAccess(
           contentFrame()->securityContext()->getSecurityOrigin()))
     return false;
-  return document().frame()->isURLAllowed(completeURL);
+  return true;

[dcheng, 2017/02/12 08:34:59]

Nit: it's a really long return, but the usual convention is to just:

return !condition;

instead of

if (condition)
  return false;
return true;

[davidsac (gone - try alexmos), 2017/02/14 00:50:03]

Done.

 }
 
 // We don't use m_url, or m_serviceType as they may not be the final values
 // that <object> uses depending on <param> values.
 bool HTMLPlugInElement::wouldLoadAsNetscapePlugin(const String& url,
                                                   const String& serviceType) {
   DCHECK(document().frame());
   KURL completedURL;
   if (!url.isEmpty())
     completedURL = document().completeURL(url);
@@ skipping 165 matching lines @@
 
 void HTMLPlugInElement::lazyReattachIfNeeded() {
   if (!useFallbackContent() && needsWidgetUpdate() && layoutObject() &&
       !isImageType()) {
     lazyReattachIfAttached();
     setPersistedPluginWidget(nullptr);
   }
 }
 
 }  // namespace blink