Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 2528813002: Fix Self-Referencing OOPIF Infinite Loop (Closed)
Patch Set: make EqualIgnoringFragmentIdentifier more efficient Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
7 7
8 #include "content/public/browser/navigation_handle.h" 8 #include "content/public/browser/navigation_handle.h"
9 9
10 #include <stddef.h> 10 #include <stddef.h>
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 // Helper function to run and reset the |complete_callback_|. This marks the 361 // Helper function to run and reset the |complete_callback_|. This marks the
362 // end of a round of NavigationThrottleChecks. 362 // end of a round of NavigationThrottleChecks.
363 void RunCompleteCallback(NavigationThrottle::ThrottleCheckResult result); 363 void RunCompleteCallback(NavigationThrottle::ThrottleCheckResult result);
364 364
365 // Used in tests. 365 // Used in tests.
366 State state() const { return state_; } 366 State state() const { return state_; }
367 367
368 // Populates |throttles_| with the throttles for this navigation. 368 // Populates |throttles_| with the throttles for this navigation.
369 void RegisterNavigationThrottles(); 369 void RegisterNavigationThrottles();
370 370
371 // Checks for attempts to navigate to a page that is already referenced more
372 // than once in the frame's ancestors. This is a helper function used by
373 // WillStartRequest and WillRedirectRequest to prevent the navigation.
374 bool IsSelfReferentialURL();
375
371 // See NavigationHandle for a description of those member variables. 376 // See NavigationHandle for a description of those member variables.
372 GURL url_; 377 GURL url_;
373 scoped_refptr<SiteInstance> starting_site_instance_; 378 scoped_refptr<SiteInstance> starting_site_instance_;
374 Referrer sanitized_referrer_; 379 Referrer sanitized_referrer_;
375 bool has_user_gesture_; 380 bool has_user_gesture_;
376 ui::PageTransition transition_; 381 ui::PageTransition transition_;
377 bool is_external_protocol_; 382 bool is_external_protocol_;
378 net::Error net_error_code_; 383 net::Error net_error_code_;
379 RenderFrameHostImpl* render_frame_host_; 384 RenderFrameHostImpl* render_frame_host_;
380 const bool is_renderer_initiated_; 385 const bool is_renderer_initiated_;
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
478 net::HostPortPair socket_address_; 483 net::HostPortPair socket_address_;
479 484
480 base::WeakPtrFactory<NavigationHandleImpl> weak_factory_; 485 base::WeakPtrFactory<NavigationHandleImpl> weak_factory_;
481 486
482 DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl); 487 DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl);
483 }; 488 };
484 489
485 } // namespace content 490 } // namespace content
486 491
487 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_ 492 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698