Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 2528813002: Fix Self-Referencing OOPIF Infinite Loop (Closed)
Patch Set: actually fix broken test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
7 7
8 #include "content/public/browser/navigation_handle.h" 8 #include "content/public/browser/navigation_handle.h"
9 9
10 #include <stddef.h> 10 #include <stddef.h>
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 // Helper function to run and reset the |complete_callback_|. This marks the 346 // Helper function to run and reset the |complete_callback_|. This marks the
347 // end of a round of NavigationThrottleChecks. 347 // end of a round of NavigationThrottleChecks.
348 void RunCompleteCallback(NavigationThrottle::ThrottleCheckResult result); 348 void RunCompleteCallback(NavigationThrottle::ThrottleCheckResult result);
349 349
350 // Used in tests. 350 // Used in tests.
351 State state() const { return state_; } 351 State state() const { return state_; }
352 352
353 // Populates |throttles_| with the throttles for this navigation. 353 // Populates |throttles_| with the throttles for this navigation.
354 void RegisterNavigationThrottles(); 354 void RegisterNavigationThrottles();
355 355
356 // Checks for attempts to navigate to a page that is already referenced more
357 // than once in the frame's ancestors. This is a helper function used by
358 // WillStartRequest and WillRedirectRequest to prevent the navigation.
359 bool IsSelfReferentialURL();
360
356 // See NavigationHandle for a description of those member variables. 361 // See NavigationHandle for a description of those member variables.
357 GURL url_; 362 GURL url_;
358 scoped_refptr<SiteInstance> starting_site_instance_; 363 scoped_refptr<SiteInstance> starting_site_instance_;
359 Referrer sanitized_referrer_; 364 Referrer sanitized_referrer_;
360 bool has_user_gesture_; 365 bool has_user_gesture_;
361 ui::PageTransition transition_; 366 ui::PageTransition transition_;
362 bool is_external_protocol_; 367 bool is_external_protocol_;
363 net::Error net_error_code_; 368 net::Error net_error_code_;
364 RenderFrameHostImpl* render_frame_host_; 369 RenderFrameHostImpl* render_frame_host_;
365 const bool is_renderer_initiated_; 370 const bool is_renderer_initiated_;
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 std::string searchable_form_encoding_; 459 std::string searchable_form_encoding_;
455 460
456 base::WeakPtrFactory<NavigationHandleImpl> weak_factory_; 461 base::WeakPtrFactory<NavigationHandleImpl> weak_factory_;
457 462
458 DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl); 463 DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl);
459 }; 464 };
460 465
461 } // namespace content 466 } // namespace content
462 467
463 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_ 468 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698