content/test/data/page_with_meta_refresh_frame.html - Issue 2528813002: Fix Self-Referencing OOPIF Infinite Loop

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/page_with_meta_refresh_frame.html

Issue 2528813002: Fix Self-Referencing OOPIF Infinite Loop (Closed)

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <title>test</title>

	5 <script>

	6 window.addEventListener("load", populateIframe);

	7 function populateIframe() {

	8 html = "<!doctype html>" +

	9 "<html>" +

	10 " <head>" +

	11 " <meta http-equiv=\"refresh\" content=\"3\">" +
	alexmos 2017/01/06 02:27:29 Let's use "0" here to not slow down the tests on t Let's use "0" here to not slow down the tests on the bots :) davidsac (gone - try alexmos) 2017/01/19 18:26:24 Done. Show quoted text On 2017/01/06 02:27:29, alexmos wrote: > Let's use "0" here to not slow down the tests on the bots :) Done.
	12 " <title>meta refresh in iframe reloads parent</title>" +

	13 " </head>" +

	14 " <body>" +

	15 " iframe" +

	16 " </body>" +

	17 "</html>";

	18 doc = document.getElementById("frame").contentDocument;

	19 doc.open();
	alexmos 2017/01/06 02:27:30 Let's add a comment that this will overwrite the i Let's add a comment that this will overwrite the iframe document's URL with the URL of the parent document. (Since this is the most non-obvious part of this code.) davidsac (gone - try alexmos) 2017/01/19 18:26:24 Done. Show quoted text On 2017/01/06 02:27:30, alexmos wrote: > Let's add a comment that this will overwrite the iframe document's URL with the > URL of the parent document. (Since this is the most non-obvious part of this > code.) Done.
	20 doc.write(html);

	21 doc.close();

	22 }

	23 </script>

	24 </head>

	25 <body>

	26 <div>parent</div>

	27 <iframe id="frame"></iframe>

	28 </body>

	29 </html>

OLD	NEW