Fix Self-Referencing OOPIF Infinite Loop

content/browser/site_per_process_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/site_per_process_browsertest.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 8961 matching lines @@
   // handler and sends the swapout ACK.
   rfh->OnSwappedOut();
 
   // Wait for the new a.com navigation to finish.
   back_observer.Wait();
 
   // The RVH for a.com should've been reused, and it should be active.
   EXPECT_TRUE(rvh->is_active());
 }
 
+// Ensure that loading a page with a cross-site coreferencing iframe
+// does not cause an infinite number of nested iframes to be created.
+// TODO(davidsac): This test should be broken until issue 650332 is resolved.
+// Also, a decision of how to handle the issue will determine what FrameTree
+// string to expect
+IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, CoReferencingFrames) {

[alexmos, 2016/12/28 00:25:59]

This test looks identical to the one above in RenderFrameHostManagerTest, which
has coverage both without and with --site-per-process (the latter on our FYI
bots and try bot).  Can it be removed, or was there a reason for keeping it?

[davidsac (gone - try alexmos), 2017/01/06 00:44:58]

It has been removed. :)  I think when I first wrote both tests, I didn't realize
that RenderFrameHostManagerTest was run in both modes.

+  // Load a page with a cross-site coreferencing iframe.
+  GURL url_1(
+      embedded_test_server()->GetURL("a.com", "/coreferencingframe_1.html"));
+  EXPECT_TRUE(NavigateToURL(shell(), url_1));
+
+  FrameTreeNode* root = web_contents()->GetFrameTree()->root();
+
+  // The Frame Tree contains two successful instances of each site plus an
+  // unsuccessfully-navigated third instance of B with a blank URL.
+  EXPECT_EQ(
+      " Site A ------------ proxies for B\n"
+      "   +--Site B ------- proxies for A\n"
+      "        +--Site A -- proxies for B\n"
+      "             +--Site B -- proxies for A\n"
+      "                  +--Site B -- proxies for A\n"
+      "Where A = http://a.com/\n"
+      "      B = http://b.com/",
+      DepictFrameTree(root));
+
+  EXPECT_EQ(
+      root->child_at(0)->child_at(0)->child_at(0)->child_at(0)->current_url(),
+      "");
+}
+
 }  // namespace content