Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2528793002:
[Mac] Remove omnibox default Touch Bar items (Closed)
|
Created:
4 years ago by spqchan Modified:
4 years ago Reviewers:
Robert Sesek CC:
chromium-reviews, mac-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Mac] Remove omnibox default touch bar items
BUG=661676
Committed: https://crrev.com/542e45d1534440fcb5b9f3d6864d6d13df293b9c
Cr-Commit-Position: refs/heads/master@{#434700}
Patch Set 1 #Patch Set 2 : Added foward declaration #Messages
Total messages: 25 (19 generated)
Description was changed from ========== [Mac] Remove omnibox default Touch Bar items BUG= ========== to ========== [Mac] Remove omnibox default touch bar items BUG=661676 ==========
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
spqchan@chromium.org changed reviewers: + rsesek@chromium.org
PTAL
LGTM
On 2016/11/28 17:41:08, Robert Sesek wrote: > LGTM thanks!
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480356162962620,
"parent_rev": "c4d0efad04011afd1c974aefeda36c841b835a5d", "commit_rev":
"83d99f7d19b087758494d75c73c154fa35285bad"}
Message was sent while issue was closed.
Description was changed from ========== [Mac] Remove omnibox default touch bar items BUG=661676 ========== to ========== [Mac] Remove omnibox default touch bar items BUG=661676 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Mac] Remove omnibox default touch bar items BUG=661676 ========== to ========== [Mac] Remove omnibox default touch bar items BUG=661676 Committed: https://crrev.com/542e45d1534440fcb5b9f3d6864d6d13df293b9c Cr-Commit-Position: refs/heads/master@{#434700} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/542e45d1534440fcb5b9f3d6864d6d13df293b9c Cr-Commit-Position: refs/heads/master@{#434700} |
