Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1385)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2528743002: Shape Detection: Implement FaceDetection on Mac as out-of-process service (Closed)
Patch Set: avi@ comments, rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/BUILD.gn » ('j') | content/browser/browser_context.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 7bfe7f132a103cd7f7d1ae8e2c075f57265ef5a0..0a03021c2326df4027e0aadee3b0833097b74370 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -2332,20 +2332,19 @@ bool ChromeContentBrowserClient::CanCreateWindow(
InfoMap* map = io_data->GetExtensionInfoMap();
const Extension* extension =
map->extensions().GetExtensionOrAppByURL(opener_url);
+ // TODO(lazyboy): http://crbug.com/585570, if |extension| is a platform app,
+ // disallow loading it in a tab via window.open(). Currently there are apps
+ // that rely on this to be allowed to get Cast API to work, so we are
+ // allowing this temporarily. Once Media Router is available on stable, this
+ // exception should not be required.
if (extension && extension->is_platform_app()) {
AppLoadedInTabSource source =
opener_top_level_frame_url ==
extensions::BackgroundInfo::GetBackgroundURL(extension)
? APP_LOADED_IN_TAB_SOURCE_BACKGROUND_PAGE
: APP_LOADED_IN_TAB_SOURCE_APP;
- // TODO(lazyboy): Remove this UMA once the change below to disallow apps
- // in tabs has settled in stable branch.
UMA_HISTOGRAM_ENUMERATION("Extensions.AppLoadedInTab", source,
APP_LOADED_IN_TAB_SOURCE_MAX);
- // Platform apps and their background pages should not be able to call
- // window.open() to load v2 apps in regular tab.
- // Simply disallow window.open() calls in this case.
- return false;
}
}
#endif
« no previous file with comments | « no previous file | content/browser/BUILD.gn » ('j') | content/browser/browser_context.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698