Shape Detection: Implement FaceDetection on Mac as out-of-process service

content/browser/service_manager/service_manager_context.cc

Index: content/browser/service_manager/service_manager_context.cc
diff --git a/content/browser/service_manager/service_manager_context.cc b/content/browser/service_manager/service_manager_context.cc
index ff08a43f16173598fba6479a99a88f69aaf4a133..fd3e5f1701823f42684cacfccf970ce9d942c2b4 100644
--- a/content/browser/service_manager/service_manager_context.cc
+++ b/content/browser/service_manager/service_manager_context.cc
@@ -14,6 +14,7 @@
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/single_thread_task_runner.h"
+#include "base/strings/utf_string_conversions.h"
 #include "content/browser/gpu/gpu_process_host.h"
 #include "content/browser/service_manager/merge_dictionary.h"
 #include "content/common/service_manager/service_manager_connection_impl.h"
@@ -38,6 +39,7 @@
 #include "services/service_manager/public/interfaces/service.mojom.h"
 #include "services/service_manager/runner/common/client_util.h"
 #include "services/service_manager/service_manager.h"
+#include "services/shape_detection/public/interfaces/constants.mojom.h"
 
 namespace content {
 
@@ -311,6 +313,9 @@ ServiceManagerContext::ServiceManagerContext() {
   GetContentClient()
       ->browser()
       ->RegisterUnsandboxedOutOfProcessServices(&unsandboxed_services);
+  unsandboxed_services.insert(

[Robert Sesek, 2017/01/17 20:30:50]

What is the plan for sandboxing this?

[xianglu, 2017/01/17 22:37:29]

I think we probably don't need to sandbox this for now since browser process is
only used to forward the request to utility process. After that renderer is
connected to service directly. Nothing is sent back to browser process. So even
if utility process is compromised, it won't affect the browser.

[Robert Sesek, 2017/01/18 05:29:21]

An un-sandboxed utility process has the same capabilities and security principal
as the browser process. Isolating this code in a utility process is a good and
necessary first step, and it increases the robustness in terms of fault (crash)
tolerance. But from the security perspective, there is little difference between
an un-sandboxed utility process and the browser process.

+      std::make_pair(shape_detection::mojom::kServiceName,
+                     base::ASCIIToUTF16("Shape Detection Service")));

[Robert Sesek, 2017/01/17 20:30:50]

Can this not use the display name from the mojom too?

   for (const auto& service : unsandboxed_services) {
     ServiceManagerConnection::GetForProcess()->AddServiceRequestHandler(
         service.first,