Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2528713003: DevTools: fix exception when setting a breakpoint in sourcemap source (Closed)

Created:
4 years ago by lushnikov
Modified:
4 years ago
Reviewers:
kozy, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix exception when setting a breakpoint in sourcemap source The following scenario takes place on reload: 1. The breakpoint gets hit in dist.js 2. The dist.js has a sourceMap which is not yet loaded. For this reason, stubs are created for the sourcemaps sources. SourceMapping gets changed to actually point to the stub 3. The execution line gets revealed in the stub 4. JavaScriptSourceFrame attempts to put a breakpoint in a stub. However, since the stub is just a few lines of text, there's no linehandle for the breakpoint linenumber. This is essentially an issue inside TextPositionPositionHandle. BUG=668242 TBR=kozyatinskiy, dgozman Committed: https://crrev.com/b33d093abe57100f572b4901dbcfac5d5489f121 Cr-Commit-Position: refs/heads/master@{#434262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528713003/1
4 years ago (2016-11-23 20:07:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 22:01:43 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-23 22:03:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b33d093abe57100f572b4901dbcfac5d5489f121
Cr-Commit-Position: refs/heads/master@{#434262}

Powered by Google App Engine
This is Rietveld 408576698