Fix some FTP DCHECKs on 1xx responses.

Fix some FTP DCHECKs on 1xx responses.

A bunch of FTP response handlers did not have explicit handling for
these responses, so fell through to the non-FTP response DCHECK.
This code makes those responses now result in ERR_INVALID_RESPONSE.

BUG=667798
Committed: https://crrev.com/bc5e865358135a53401254798a54e0e8786a75ef
Cr-Commit-Position: refs/heads/master@{#434294}

[mmenke, 2016-11-23 18:08:28]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 18:09:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 20:27:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 20:27:07]

Dry run: This issue passed the CQ dry run.

[mmenke, 2016-11-23 20:41:57]

mmenke@chromium.org changed reviewers:
+ eroman@chromium.org

[mmenke, 2016-11-23 20:41:57]

Exciting CLs like this are what make fuzzing worth all the effort!

[eroman, 2016-11-23 20:46:41]

lgtm

https://codereview.chromium.org/2528713002/diff/1/net/ftp/ftp_network_transac...
File net/ftp/ftp_network_transaction.cc (right):

https://codereview.chromium.org/2528713002/diff/1/net/ftp/ftp_network_transac...
net/ftp/ftp_network_transaction.cc:768: default:
Can you remove the default case?

https://codereview.chromium.org/2528713002/diff/1/net/ftp/ftp_network_transac...
net/ftp/ftp_network_transaction.cc:800: default:
ditto.

[mmenke, 2016-11-23 20:52:34]

https://codereview.chromium.org/2528713002/diff/1/net/ftp/ftp_network_transac...
File net/ftp/ftp_network_transaction.cc (right):

https://codereview.chromium.org/2528713002/diff/1/net/ftp/ftp_network_transac...
net/ftp/ftp_network_transaction.cc:768: default:
On 2016/11/23 20:46:41, eroman (slow) wrote:
> Can you remove the default case?

Done, removed them all (There are 11 methods just like this).

[mmenke, 2016-11-23 20:52:38]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2016-11-23 20:52:38]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2528713002/#ps20001
(title: "Remove defaul cases")

[commit-bot: I haz the power, 2016-11-23 20:53:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 00:15:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479934358287010,
"parent_rev": "cfa9d8ad605c16d79bbebd7943918fe15c78464d", "commit_rev":
"d949383b32355dcf166239bd334265ceb3795b0f"}

[commit-bot: I haz the power, 2016-11-24 00:15:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-24 00:17:18]

Description was changed from

==========
Fix some FTP DCHECKs on 1xx responses.

A bunch of FTP response handlers did not have explicit handling for
these responses, so fell through to the non-FTP response DCHECK.
This code makes those responses now result in ERR_INVALID_RESPONSE.

BUG=667798
==========

to

==========
Fix some FTP DCHECKs on 1xx responses.

A bunch of FTP response handlers did not have explicit handling for
these responses, so fell through to the non-FTP response DCHECK.
This code makes those responses now result in ERR_INVALID_RESPONSE.

BUG=667798

Committed: https://crrev.com/bc5e865358135a53401254798a54e0e8786a75ef
Cr-Commit-Position: refs/heads/master@{#434294}
==========

[commit-bot: I haz the power, 2016-11-24 00:17:19]

Patchset 2 (id:??) landed as
https://crrev.com/bc5e865358135a53401254798a54e0e8786a75ef
Cr-Commit-Position: refs/heads/master@{#434294}