third_party/WebKit/Source/core/html/HTMLTableElement.cpp - Issue 2528673003: Rework the "rules for parsing dimension values" implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTableElement.cpp

Issue 2528673003: Rework the "rules for parsing dimension values" implementation (Closed)

Patch Set: Rebase; clarify comment. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLTableElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTableElement.cpp b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp

index 23cfa78d85d8d39b1c60229ae08aadf51b00091a..a3fdf43e2bd02e81fb470857873e1a8385aec627 100644

--- a/third_party/WebKit/Source/core/html/HTMLTableElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp

@@ -328,8 +328,10 @@ void HTMLTableElement::collectStyleForPresentationAttribute(

addPropertyToPresentationAttributeStyle(style, CSSPropertyVerticalAlign,

value);

} else if (name == cellspacingAttr) {

- if (!value.isEmpty())

- addHTMLLengthToStyle(style, CSSPropertyBorderSpacing, value);

+ if (!value.isEmpty()) {

+ addHTMLLengthToStyle(style, CSSPropertyBorderSpacing, value,

+ DontAllowPercentageValues);

+ }

} else if (name == alignAttr) {

if (!value.isEmpty()) {

if (equalIgnoringCase(value, "center")) {

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLElement.cpp ('k') | no next file » | no next file with comments »