Rework the "rules for parsing dimension values" implementation

third_party/WebKit/Source/core/html/HTMLElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004-2008, 2013, 2014 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2011 Motorola Mobility. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 33 matching lines @@
 #include "core/dom/shadow/ElementShadow.h"
 #include "core/dom/shadow/FlatTreeTraversal.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/editing/EditingUtilities.h"
 #include "core/editing/serializers/Serialization.h"
 #include "core/events/EventListener.h"
 #include "core/events/KeyboardEvent.h"
 #include "core/frame/Settings.h"
 #include "core/frame/UseCounter.h"
 #include "core/html/HTMLBRElement.h"
+#include "core/html/HTMLDimension.h"
 #include "core/html/HTMLFormElement.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLMenuElement.h"
 #include "core/html/HTMLTemplateElement.h"
 #include "core/html/parser/HTMLParserIdioms.h"
 #include "core/layout/LayoutBoxModelObject.h"
 #include "core/layout/LayoutObject.h"
 #include "core/page/SpatialNavigation.h"
 #include "core/svg/SVGSVGElement.h"
 #include "platform/Language.h"
@@ skipping 831 matching lines @@
        elementToAdjust = FlatTreeTraversal::parentElement(*elementToAdjust)) {
     if (elementAffectsDirectionality(elementToAdjust)) {
       toHTMLElement(elementToAdjust)->calculateAndAdjustDirectionality();
       return;
     }
   }
 }
 
 void HTMLElement::addHTMLLengthToStyle(MutableStylePropertySet* style,
                                        CSSPropertyID propertyID,
-                                       const String& value) {
-  // FIXME: This function should not spin up the CSS parser, but should instead
-  // just figure out the correct length unit and make the appropriate parsed
-  // value.
-
-  // strip attribute garbage..
-  StringImpl* v = value.impl();
-  if (v) {
-    unsigned length = 0;
-
-    while (length < v->length() && (*v)[length] <= ' ')
-      length++;
-
-    for (; length < v->length(); length++) {
-      UChar cc = (*v)[length];
-      if (cc > '9')
-        break;
-      if (cc < '0') {
-        if (cc == '%' || cc == '*') {
-          if (propertyID == CSSPropertyWidth)
-            UseCounter::count(document(),
-                              UseCounter::HTMLElementDeprecatedWidth);
-          length++;
-        }
-        if (cc != '.')
-          break;
-      }
-    }
-
-    if (length != v->length()) {
-      addPropertyToPresentationAttributeStyle(style, propertyID,
-                                              v->substring(0, length));
-      return;
-    }
+                                       const String& value,
+                                       AllowPercentage allowPercentage) {
+  HTMLDimension dimension;
+  if (!parseDimensionValue(value, dimension))
+    return;
+  if (propertyID == CSSPropertyWidth &&
+      (dimension.isPercentage() || dimension.isRelative())) {
+    UseCounter::count(document(), UseCounter::HTMLElementDeprecatedWidth);
   }
-
-  addPropertyToPresentationAttributeStyle(style, propertyID, value);
+  if (dimension.isRelative())
+    return;
+  if (dimension.isPercentage() && allowPercentage != AllowPercentageValues)
+    return;
+  CSSPrimitiveValue::UnitType unit =
+      dimension.isPercentage() ? CSSPrimitiveValue::UnitType::Percentage
+                               : CSSPrimitiveValue::UnitType::Pixels;
+  addPropertyToPresentationAttributeStyle(style, propertyID, dimension.value(),
+                                          unit);
 }
 
 static RGBA32 parseColorStringWithCrazyLegacyRules(const String& colorString) {
   // Per spec, only look at the first 128 digits of the string.
   const size_t maxColorLength = 128;
   // We'll pad the buffer with two extra 0s later, so reserve two more than the
   // max.
   Vector<char, maxColorLength + 2> digitBuffer;
 
   size_t i = 0;
@@ skipping 250 matching lines @@
 
 #ifndef NDEBUG
 
 // For use in the debugger
 void dumpInnerHTML(blink::HTMLElement*);
 
 void dumpInnerHTML(blink::HTMLElement* element) {
   printf("%s\n", element->innerHTML().ascii().data());
 }
 #endif