Rework the "rules for parsing dimension values" implementation

third_party/WebKit/Source/core/html/HTMLDimensionTest.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 180 matching lines @@
 
 TEST(HTMLDimensionTest, parseListOfDimensionsMultipleDimensionsWithOneEmpty) {
   Vector<HTMLDimension> result = parseListOfDimensions(String("2*,,8.%"));
 
   ASSERT_EQ(3U, result.size());
   ASSERT_EQ(HTMLDimension(2, HTMLDimension::Relative), result[0]);
   ASSERT_EQ(HTMLDimension(0, HTMLDimension::Relative), result[1]);
   ASSERT_EQ(HTMLDimension(8., HTMLDimension::Percentage), result[2]);
 }
 
+TEST(HTMLDimensionTest, parseDimensionValueEmptyString) {
+  HTMLDimension dimension;
+  EXPECT_FALSE(parseDimensionValue(String(""), dimension));
+}
+
+TEST(HTMLDimensionTest, parseDimensionValueSpacesOnly) {
+  HTMLDimension dimension;
+  EXPECT_FALSE(parseDimensionValue(String("     "), dimension));
+}
+
+TEST(HTMLDimensionTest, parseDimensionValueAllowedSpaces) {
+  HTMLDimension dimension;
+  EXPECT_TRUE(parseDimensionValue(String(" \t\f\r\n10"), dimension));
+  EXPECT_EQ(HTMLDimension(10, HTMLDimension::Absolute), dimension);
+}
+
+TEST(HTMLDimensionTest, parseDimensionValueLeadingPlus) {
+  HTMLDimension dimension;
+  EXPECT_FALSE(parseDimensionValue(String("+10"), dimension));
+}
+
+TEST(HTMLDimensionTest, parseDimensionValueAbsolute) {
+  HTMLDimension dimension;
+  EXPECT_TRUE(parseDimensionValue(String("10"), dimension));
+  EXPECT_EQ(HTMLDimension(10, HTMLDimension::Absolute), dimension);
+}
+
+TEST(HTMLDimensionTest, parseDimensionValueAbsoluteFraction) {
+  HTMLDimension dimension;
+  EXPECT_TRUE(parseDimensionValue(String("10.50"), dimension));
+  EXPECT_EQ(HTMLDimension(10.5, HTMLDimension::Absolute), dimension);
+}
+
+TEST(HTMLDimensionTest, parseDimensionValueAbsoluteDotNoFraction) {
+  HTMLDimension dimension;
+  EXPECT_TRUE(parseDimensionValue(String("10.%"), dimension));
+  EXPECT_EQ(HTMLDimension(10, HTMLDimension::Percentage), dimension);
+}
+
+TEST(HTMLDimensionTest, parseDimensionValueAbsoluteTrailingGarbage) {
+  HTMLDimension dimension;
+  EXPECT_TRUE(parseDimensionValue(String("10foo"), dimension));
+  EXPECT_EQ(HTMLDimension(10, HTMLDimension::Absolute), dimension);
+}
+
+TEST(HTMLDimensionTest, parseDimensionValueAbsoluteTrailingGarbageAfterSpace) {
+  HTMLDimension dimension;
+  EXPECT_TRUE(parseDimensionValue(String("10 foo"), dimension));
+  EXPECT_EQ(HTMLDimension(10, HTMLDimension::Absolute), dimension);
+}
+
+TEST(HTMLDimensionTest, parseDimensionValuePercentage) {
+  HTMLDimension dimension;
+  EXPECT_TRUE(parseDimensionValue(String("10%"), dimension));
+  EXPECT_EQ(HTMLDimension(10, HTMLDimension::Percentage), dimension);
+}
+
+TEST(HTMLDimensionTest, parseDimensionValueRelative) {
+  HTMLDimension dimension;
+  EXPECT_TRUE(parseDimensionValue(String("10*"), dimension));
+  EXPECT_EQ(HTMLDimension(10, HTMLDimension::Relative), dimension);
+}
+
+TEST(HTMLDimensionTest, parseDimensionValueInvalidNumberFormatDot) {
+  HTMLDimension dimension;
+  EXPECT_FALSE(parseDimensionValue(String(".50"), dimension));
+}
+
+TEST(HTMLDimensionTest, parseDimensionValueInvalidNumberFormatExponent) {
+  HTMLDimension dimension;
+  EXPECT_TRUE(parseDimensionValue(String("10e10"), dimension));
+  EXPECT_EQ(HTMLDimension(10, HTMLDimension::Absolute), dimension);
+}
+
 }  // namespace blink