Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2528673002: VM: [Kernel] Don't emit ReturnInstr that are not connected to the graph. (Closed)

Created:
4 years ago by Vyacheslav Egorov (Google)
Modified:
4 years ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: [Kernel] Don't emit ReturnInstr that are not connected to the graph. This breaks inlining because it expects that all collected ReturnInstr are strongly connected to the rest of the graph. Source based FlowGraphBuilder achieves that by eagerly stopping construction as constructed fragment is closed (e.g. Throw is emitted). R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/584788a47c5433ff2db2ffff03a3a33cecbb17ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M runtime/vm/kernel_to_il.cc View 2 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
4 years ago (2016-11-23 15:20:15 UTC) #1
kustermann
lgtm
4 years ago (2016-11-24 12:18:22 UTC) #2
Vyacheslav Egorov (Google)
4 years ago (2016-11-24 15:19:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
584788a47c5433ff2db2ffff03a3a33cecbb17ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698