Move MediaQueryResults to RuleFeatureSet.

Move MediaQueryResults to RuleFeatureSet.

The existing code only cleared the query results on the StyleResolver
when the StyleResolver was cleared. That meant we could end up in a
situation where the result list was ever-growing. That wasn't a big
issue in practice as the StyleResolver would be cleared quite often on
stylesheet changes. However, that will change when the RuleSet based
style invalidation is enabled.

We move the media query results to RuleFeatureSet so that:

- Results for @media rules are stored in RuleFeatureSet instead of
  RuleSet.
- Results for media attributes are stored in the ScopedStyleResolver
  when added instead of appending them directly to StyleResolver.
- Accumulated results for all scopes are stored in CSSGlobalRuleSet
  on StyleEngine instead of StyleResolver and are accumulated with
  other rule features in ScopedStyleResolver::collectFeaturesTo().

This CL introduces StyleEngine::ruleSetForSheet() for evaluating the
media attribute of the stylesheet node and create the RuleSet if the
media attribute matches. That way we are able to make the
MediaQueryEvaluator private to StyleEngine. Also, this method is
required when we start using ActiveStyleSheets.

R=meade@chromium.org
BUG=567021, 614026
Committed: https://crrev.com/4462ce68a6f0808d4f3d7e530b4920250d3675fd
Cr-Commit-Position: refs/heads/master@{#434383}

[rune, 2016-11-23 13:24:04]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 13:24:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 13:35:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 13:35:49]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)

[rune, 2016-11-23 13:37:42]

https://codereview.chromium.org/2528633003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/resolver/StyleResolver.h (right):

https://codereview.chromium.org/2528633003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/resolver/StyleResolver.h:278:
MediaQueryResultList m_deviceDependentMediaQueryResults;
These should have been removed.

[rune, 2016-11-23 13:46:54]

https://codereview.chromium.org/2528633003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/resolver/StyleResolver.h (right):

https://codereview.chromium.org/2528633003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/resolver/StyleResolver.h:278:
MediaQueryResultList m_deviceDependentMediaQueryResults;
On 2016/11/23 13:37:42, rune wrote:
> These should have been removed.

Done.

[rune, 2016-11-23 13:47:01]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 13:47:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 15:17:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 15:17:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rune, 2016-11-23 15:48:44]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 15:49:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 19:22:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 19:22:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nainar, 2016-11-24 06:36:19]

nainar@chromium.org changed reviewers:
+ nainar@chromium.org

[nainar, 2016-11-24 06:36:19]

lgtm

[meade_UTC10, 2016-11-24 06:36:27]

lgtm

[rune, 2016-11-24 09:54:27]

The CQ bit was checked by rune@opera.com

[rune, 2016-11-24 09:54:27]

The CQ bit was unchecked by rune@opera.com

[rune, 2016-11-24 09:54:28]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-11-24 09:54:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 11:55:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 11:55:41]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[rune, 2016-11-24 18:19:08]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-11-24 18:19:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 19:50:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480011548316230,
"parent_rev": "ef43545d79a9ea2c39f82b7154fa188f7ac574d3", "commit_rev":
"f046741bba1750ff45117d8b5f6697d5eeb02267"}

[commit-bot: I haz the power, 2016-11-24 19:50:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-24 19:52:54]

Description was changed from

==========
Move MediaQueryResults to RuleFeatureSet.

The existing code only cleared the query results on the StyleResolver
when the StyleResolver was cleared. That meant we could end up in a
situation where the result list was ever-growing. That wasn't a big
issue in practice as the StyleResolver would be cleared quite often on
stylesheet changes. However, that will change when the RuleSet based
style invalidation is enabled.

We move the media query results to RuleFeatureSet so that:

- Results for @media rules are stored in RuleFeatureSet instead of
  RuleSet.
- Results for media attributes are stored in the ScopedStyleResolver
  when added instead of appending them directly to StyleResolver.
- Accumulated results for all scopes are stored in CSSGlobalRuleSet
  on StyleEngine instead of StyleResolver and are accumulated with
  other rule features in ScopedStyleResolver::collectFeaturesTo().

This CL introduces StyleEngine::ruleSetForSheet() for evaluating the
media attribute of the stylesheet node and create the RuleSet if the
media attribute matches. That way we are able to make the
MediaQueryEvaluator private to StyleEngine. Also, this method is
required when we start using ActiveStyleSheets.

R=meade@chromium.org
BUG=567021,614026
==========

to

==========
Move MediaQueryResults to RuleFeatureSet.

The existing code only cleared the query results on the StyleResolver
when the StyleResolver was cleared. That meant we could end up in a
situation where the result list was ever-growing. That wasn't a big
issue in practice as the StyleResolver would be cleared quite often on
stylesheet changes. However, that will change when the RuleSet based
style invalidation is enabled.

We move the media query results to RuleFeatureSet so that:

- Results for @media rules are stored in RuleFeatureSet instead of
  RuleSet.
- Results for media attributes are stored in the ScopedStyleResolver
  when added instead of appending them directly to StyleResolver.
- Accumulated results for all scopes are stored in CSSGlobalRuleSet
  on StyleEngine instead of StyleResolver and are accumulated with
  other rule features in ScopedStyleResolver::collectFeaturesTo().

This CL introduces StyleEngine::ruleSetForSheet() for evaluating the
media attribute of the stylesheet node and create the RuleSet if the
media attribute matches. That way we are able to make the
MediaQueryEvaluator private to StyleEngine. Also, this method is
required when we start using ActiveStyleSheets.

R=meade@chromium.org
BUG=567021,614026

Committed: https://crrev.com/4462ce68a6f0808d4f3d7e530b4920250d3675fd
Cr-Commit-Position: refs/heads/master@{#434383}
==========

[commit-bot: I haz the power, 2016-11-24 19:52:55]

Patchset 2 (id:??) landed as
https://crrev.com/4462ce68a6f0808d4f3d7e530b4920250d3675fd
Cr-Commit-Position: refs/heads/master@{#434383}