Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2528623003:
Remove shelf_view_unittest's ScopedMockTaskRunnerWrapper copy. (Closed)
|
Created:
4 years ago by msw Modified:
4 years ago Reviewers:
James Cook CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove shelf_view_unittest's ScopedMockTaskRunnerWrapper copy.
Use the common class from base instead.
BUG=NONE
TEST=Automated
R=jamescook@chromium.org
Committed: https://crrev.com/be556b7691d1d10eb87bafec8a23548685bf5f61
Cr-Commit-Position: refs/heads/master@{#434805}
Patch Set 1 #Patch Set 2 : Remove redundant RunAllPendingInMessageLoop() and unnecessary code block. #
Total comments: 2
Messages
Total messages: 17 (10 generated)
Hey Stefan, please take a look; thanks! (sorry the diff looks more complex than the change really is)
The CQ bit was checked by msw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Remove shelf_view_unittest's ScopedMockTaskRunnerWrapper copy. Use the common class from base instead. BUG=NONE TEST=Automated R=skuhne@chromium.org ========== to ========== Remove shelf_view_unittest's ScopedMockTaskRunnerWrapper copy. Use the common class from base instead. BUG=NONE TEST=Automated R=jamescook@chromium.org ==========
msw@chromium.org changed reviewers: + jamescook@chromium.org - skuhne@chromium.org
Hey James, please take a look; thanks! (sorry the diff looks more complex than the change really is)
LGTM https://codereview.chromium.org/2528623003/diff/20001/ash/shelf/shelf_view_un... File ash/shelf/shelf_view_unittest.cc (right): https://codereview.chromium.org/2528623003/diff/20001/ash/shelf/shelf_view_un... ash/shelf/shelf_view_unittest.cc:2865: base::ScopedMockTimeMessageLoopTaskRunner mock_task_runner; Wow, I had no idea that ScopedMockTimeMessageLoopTaskRunner was a thing. :-)
https://codereview.chromium.org/2528623003/diff/20001/ash/shelf/shelf_view_un... File ash/shelf/shelf_view_unittest.cc (right): https://codereview.chromium.org/2528623003/diff/20001/ash/shelf/shelf_view_un... ash/shelf/shelf_view_unittest.cc:2865: base::ScopedMockTimeMessageLoopTaskRunner mock_task_runner; On 2016/11/28 23:05:15, James Cook wrote: > Wow, I had no idea that ScopedMockTimeMessageLoopTaskRunner was a thing. :-) Neither did I; it came up in a review I did, and I found this copy.
The CQ bit was checked by msw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480375305925610,
"parent_rev": "707e0b59ee890ce5b4a3f6a18ef92b9342b85849", "commit_rev":
"201a49021117fe933639cc6ef32598d5a11d1200"}
Message was sent while issue was closed.
Description was changed from ========== Remove shelf_view_unittest's ScopedMockTaskRunnerWrapper copy. Use the common class from base instead. BUG=NONE TEST=Automated R=jamescook@chromium.org ========== to ========== Remove shelf_view_unittest's ScopedMockTaskRunnerWrapper copy. Use the common class from base instead. BUG=NONE TEST=Automated R=jamescook@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove shelf_view_unittest's ScopedMockTaskRunnerWrapper copy. Use the common class from base instead. BUG=NONE TEST=Automated R=jamescook@chromium.org ========== to ========== Remove shelf_view_unittest's ScopedMockTaskRunnerWrapper copy. Use the common class from base instead. BUG=NONE TEST=Automated R=jamescook@chromium.org Committed: https://crrev.com/be556b7691d1d10eb87bafec8a23548685bf5f61 Cr-Commit-Position: refs/heads/master@{#434805} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/be556b7691d1d10eb87bafec8a23548685bf5f61 Cr-Commit-Position: refs/heads/master@{#434805} |
