Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2528623002: Disable kernel unit tests. (Closed)

Created:
4 years ago by asgerf
Modified:
4 years ago
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable kernel unit tests. They are causing issues on dartium and dart2js_jsshell. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/ac21874a211aeb4173ffd679824d060bde6f77d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-8 lines, -548 lines) Patch
D pkg/kernel/test/baseline_spec_mode_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
A + pkg/kernel/test/baseline_spec_mode_test_disabled.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/kernel/test/baseline_type_propagation_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
A + pkg/kernel/test/baseline_type_propagation_test_disabled.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/kernel/test/type_hashcode_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
A + pkg/kernel/test/type_hashcode_test_disabled.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/kernel/test/type_substitute_bounds_test.dart View 1 chunk +0 lines, -84 lines 0 comments Download
A + pkg/kernel/test/type_substitute_bounds_test_disabled.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/kernel/test/type_substitution_identity_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
A + pkg/kernel/test/type_substitution_identity_test_disabled.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/kernel/test/type_subtype_test.dart View 1 chunk +0 lines, -162 lines 0 comments Download
A + pkg/kernel/test/type_subtype_test_disabled.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/kernel/test/type_unification_test.dart View 1 chunk +0 lines, -138 lines 0 comments Download
A + pkg/kernel/test/type_unification_test_disabled.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/kernel/test/uint31_pair_map_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
A + pkg/kernel/test/uint31_pair_map_test_disabled.dart View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
4 years ago (2016-11-23 12:59:38 UTC) #2
Kevin Millikin (Google)
lgtm
4 years ago (2016-11-23 13:11:53 UTC) #3
asgerf
4 years ago (2016-11-23 13:13:00 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ac21874a211aeb4173ffd679824d060bde6f77d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698