Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2528603003: Parser / PreParser: remove dead code. (Closed)

Created:
4 years ago by marja
Modified:
4 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Parser / PreParser: remove dead code. Eval calls are tracked by ParserBase::CheckPossibleEvalCall which doesn't use (Pre)?Parser::IsDirectEvalCall. Also we no longer seem to care about IsBinaryOperation (Parser didn't have it either). BUG= Committed: https://crrev.com/db1cc0cf82cbb6c075af1f37271790c8de56d861 Cr-Commit-Position: refs/heads/master@{#41216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M src/parsing/parser.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/parsing/preparser.h View 5 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
marja
ptal I bumped into this while looking at whether evals are handled in the preparser ...
4 years ago (2016-11-23 10:17:58 UTC) #2
Toon Verwaest
lgtm
4 years ago (2016-11-23 12:25:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528603003/1
4 years ago (2016-11-23 12:39:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 12:41:15 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-23 12:42:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db1cc0cf82cbb6c075af1f37271790c8de56d861
Cr-Commit-Position: refs/heads/master@{#41216}

Powered by Google App Engine
This is Rietveld 408576698