Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2528603002: [promises] Set promise context's closure to be an empty function (Closed)

Created:
4 years ago by gsathya
Modified:
4 years ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] Set promise context's closure to be an empty function This is similar to how the native context has an empty function set up as it's closure field. BUG=666984 Committed: https://crrev.com/a29b658eec3324716e39d44add188499f298c590 Cr-Commit-Position: refs/heads/master@{#41212}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/promise-utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
neis
lgtm
4 years ago (2016-11-23 11:27:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528603002/1
4 years ago (2016-11-23 12:03:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 12:05:25 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-23 12:05:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a29b658eec3324716e39d44add188499f298c590
Cr-Commit-Position: refs/heads/master@{#41212}

Powered by Google App Engine
This is Rietveld 408576698