Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3424)

Unified Diff: base/mac/mac_util.h

Issue 25286002: Update OS version functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/mac/mac_util.mm » ('j') | chrome/browser/chrome_browser_main_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/mac/mac_util.h
diff --git a/base/mac/mac_util.h b/base/mac/mac_util.h
index 23b57edaee2a983a607175c6e4ed06e963728a01..228d177929a9f0e354f5c80a8fa8dfed8d37a2c7 100644
--- a/base/mac/mac_util.h
+++ b/base/mac/mac_util.h
@@ -145,12 +145,17 @@ BASE_EXPORT bool IsOSLionOrLater();
// Mountain Lion is Mac OS X 10.8, Darwin 12.
BASE_EXPORT bool IsOSMountainLion();
+BASE_EXPORT bool IsOSMountainLionOrEarlier();
BASE_EXPORT bool IsOSMountainLionOrLater();
+// Mavericks is Mac OS X 10.9, Darwin 13.
Mark Mentovai 2013/10/01 16:15:45 As a form of civil disobedience, can we do this wi
Avi (use Gerrit) 2013/10/01 17:07:27 As idiotic as it is, that's its name.
+BASE_EXPORT bool IsOSMavericks();
+BASE_EXPORT bool IsOSMavericksOrLater();
+
// This should be infrequently used. It only makes sense to use this to avoid
// codepaths that are very likely to break on future (unreleased, untested,
// unborn) OS releases, or to log when the OS is newer than any known version.
-BASE_EXPORT bool IsOSLaterThanMountainLion_DontCallThis();
+BASE_EXPORT bool IsOSLaterThanMavericks_DontCallThis();
// When the deployment target is set, the code produced cannot run on earlier
// OS releases. That enables some of the IsOS* family to be implemented as
@@ -159,31 +164,80 @@ BASE_EXPORT bool IsOSLaterThanMountainLion_DontCallThis();
#if defined(MAC_OS_X_VERSION_10_7) && \
MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_7
-#define BASE_MAC_MAC_UTIL_H_INLINED_GE_10_7
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSSNOWLEOPARD
inline bool IsOSSnowLeopard() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSLIONORLATER
inline bool IsOSLionOrLater() { return true; }
#endif
#if defined(MAC_OS_X_VERSION_10_7) && \
MAC_OS_X_VERSION_MIN_REQUIRED > MAC_OS_X_VERSION_10_7
-#define BASE_MAC_MAC_UTIL_H_INLINED_GT_10_7
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSSNOWLEOPARD
+inline bool IsOSSnowLeopard() { return false; }
Mark Mentovai 2013/10/01 16:15:45 This will already have been defined on line 168. I
Avi (use Gerrit) 2013/10/01 17:07:27 Oh. Right.
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSLION
inline bool IsOSLion() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSLIONOREARLIER
inline bool IsOSLionOrEarlier() { return false; }
#endif
#if defined(MAC_OS_X_VERSION_10_8) && \
MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_8
-#define BASE_MAC_MAC_UTIL_H_INLINED_GE_10_8
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSSNOWLEOPARD
+inline bool IsOSSnowLeopard() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSLION
+inline bool IsOSLion() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSLIONOREARLIER
+inline bool IsOSLionOrEarlier() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSMOUNTAINLIONORLATER
inline bool IsOSMountainLionOrLater() { return true; }
#endif
#if defined(MAC_OS_X_VERSION_10_8) && \
MAC_OS_X_VERSION_MIN_REQUIRED > MAC_OS_X_VERSION_10_8
-#define BASE_MAC_MAC_UTIL_H_INLINED_GT_10_8
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSSNOWLEOPARD
+inline bool IsOSSnowLeopard() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSLION
+inline bool IsOSLion() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSMOUNTAINLION
+inline bool IsOSMountainLion() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSLIONOREARLIER
+inline bool IsOSLionOrEarlier() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSMOUNTAINLIONOREARLIER
+inline bool IsOSMountainLionOrEarlier() { return false; }
+#endif
+
+#if defined(MAC_OS_X_VERSION_10_9) && \
+ MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_9
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSSNOWLEOPARD
+inline bool IsOSSnowLeopard() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSLION
+inline bool IsOSLion() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSMOUNTAINLION
+inline bool IsOSMountainLion() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSLIONOREARLIER
+inline bool IsOSLionOrEarlier() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSMOUNTAINLIONOREARLIER
+inline bool IsOSMountainLionOrEarlier() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSMAVERICKSORLATER
+inline bool IsOSMavericksOrLater() { return true; }
+#endif
+
+#if defined(MAC_OS_X_VERSION_10_9) && \
+ MAC_OS_X_VERSION_MIN_REQUIRED > MAC_OS_X_VERSION_10_9
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSSNOWLEOPARD
+inline bool IsOSSnowLeopard() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSLION
+inline bool IsOSLion() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSMOUNTAINLION
inline bool IsOSMountainLion() { return false; }
-inline bool IsOSLaterThanMountainLion_DontCallThis() {
- return true;
-}
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSMAVERICKS
+inline bool IsOSMavericks() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSLIONOREARLIER
+inline bool IsOSLionOrEarlier() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISOSMOUNTAINLIONOREARLIER
+inline bool IsOSMountainLionOrEarlier() { return false; }
+#define BASE_MAC_MAC_UTIL_H_INLINED_ISLATERTHANOSMAVERICKS
+inline bool IsOSLaterThanMavericks_DontCallThis() { return true; }
#endif
// Retrieve the system's model identifier string from the IOKit registry:
« no previous file with comments | « no previous file | base/mac/mac_util.mm » ('j') | chrome/browser/chrome_browser_main_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698