Update OS version functions.

chrome/browser/chrome_browser_main_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main_mac.h"
 
 #import <Cocoa/Cocoa.h>
 #include <sys/sysctl.h>
 
 #include "base/command_line.h"
@@ skipping 44 matching lines @@
   SNOW_LEOPARD_64,
   LION_32,  // Unexpected, Lion requires a 64-bit CPU.
   LION_64,
   MOUNTAIN_LION_32,  // Unexpected, Mountain Lion requires a 64-bit CPU.
   MOUNTAIN_LION_64,
 
   // DON'T add new constants here. It's important to keep the constant values,
   // um, constant. Add new constants at the bottom.
 
   // Newer than any known cat.
   FUTURE_CAT_32,  // Unexpected, it's unlikely Apple will un-obsolete old CPUs.

[Mark Mentovai, 2013/10/01 18:30:59]

Since there’s no 10.10 in the wild yet in any substantial number, let’s put
sealion here (and on line 73) and move the futurecats down to the “add new
constants” section. That way, old Chromes reporting based on this enum will
report 10.9, which is the highest futurecat in the wild now. Over time, as there
are fewer and fewer old Chromes, and 10.10 starts showing up, the new Chromes
will report it using the new enum value.

You will also need to edit the internal file that contains the definitions of
these values. I can point you to that file if you don’t know where it is.

[Avi (use Gerrit), 2013/10/01 19:24:22]

Done.

   FUTURE_CAT_64,
 
   // What if the bitsiness of the CPU can't be determined?
   SABER_TOOTHED_CAT_DUNNO,
   SNOW_LEOPARD_DUNNO,
   LION_DUNNO,
   MOUNTAIN_LION_DUNNO,
   FUTURE_CAT_DUNNO,
 
   // Add new constants here.
@@ skipping 31 matching lines @@
                          SNOW_LEOPARD_DUNNO;
   }
   if (base::mac::IsOSLion()) {
     return cpu64_known ? (cpu64 ? LION_64 : LION_32) :
                          LION_DUNNO;
   }
   if (base::mac::IsOSMountainLion()) {
     return cpu64_known ? (cpu64 ? MOUNTAIN_LION_64 : MOUNTAIN_LION_32) :
                          MOUNTAIN_LION_DUNNO;
   }
-  if (base::mac::IsOSLaterThanMountainLion_DontCallThis()) {
+  if (base::mac::IsOSMavericksOrLater()) {
     return cpu64_known ? (cpu64 ? FUTURE_CAT_64 : FUTURE_CAT_32) :
                          FUTURE_CAT_DUNNO;
   }
 
   // If it's not any of the expected OS versions or later than them, it must
   // be prehistoric.
   return cpu64_known ? (cpu64 ? SABER_TOOTHED_CAT_64 : SABER_TOOTHED_CAT_32) :
                        SABER_TOOTHED_CAT_DUNNO;
 }
 
@@ skipping 132 matching lines @@
 void ChromeBrowserMainPartsMac::PostProfileInit() {
   ChromeBrowserMainPartsPosix::PostProfileInit();
   g_browser_process->metrics_service()->RecordBreakpadRegistration(
       IsCrashReporterEnabled());
 }
 
 void ChromeBrowserMainPartsMac::DidEndMainMessageLoop() {
   AppController* appController = [NSApp delegate];
   [appController didEndMainMessageLoop];
 }