Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2528593002: Revert of [cleanup] CodeStubAssembler: s/compiler::Node/Node/ (Closed)

Created:
4 years ago by Michael Hablich
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [cleanup] CodeStubAssembler: s/compiler::Node/Node/ (patchset #2 id:20001 of https://codereview.chromium.org/2519093002/ ) Reason for revert: Blocks revert of roll blocker: https://codereview.chromium.org/2528583002/ Original issue's description: > [cleanup] CodeStubAssembler: s/compiler::Node/Node/ > > Reducing visual clutter. > > Committed: https://crrev.com/36a17e87d86d2d978b64eb37044c9e9f98ebea67 > Cr-Commit-Position: refs/heads/master@{#41187} TBR=ishell@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/cfc73c3ceff5aee332218a294baa482da4ef5843 Cr-Commit-Position: refs/heads/master@{#41206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+695 lines, -520 lines) Patch
M src/code-stub-assembler.h View 13 chunks +588 lines, -443 lines 0 comments Download
M src/code-stub-assembler.cc View 34 chunks +107 lines, -77 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Hablich
Created Revert of [cleanup] CodeStubAssembler: s/compiler::Node/Node/
4 years ago (2016-11-23 08:24:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528593002/1
4 years ago (2016-11-23 08:24:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 08:24:36 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cfc73c3ceff5aee332218a294baa482da4ef5843 Cr-Commit-Position: refs/heads/master@{#41206}
4 years ago (2016-11-23 08:24:52 UTC) #7
Jakob Kummerow
4 years ago (2016-11-23 14:42:44 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2526803002/ by jkummerow@chromium.org.

The reason for reverting is: Relanding.

Powered by Google App Engine
This is Rietveld 408576698