Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/ic/accessor-assembler.cc

Issue 2528583002: Revert of [stubs] KeyedStoreGeneric: inline dictionary property stores (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | src/ic/keyed-store-generic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ic/accessor-assembler.h" 5 #include "src/ic/accessor-assembler.h"
6 #include "src/ic/accessor-assembler-impl.h" 6 #include "src/ic/accessor-assembler-impl.h"
7 7
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/ic/handler-configuration.h" 10 #include "src/ic/handler-configuration.h"
(...skipping 1349 matching lines...) Expand 10 before | Expand all | Expand 10 after
1360 // Try looking up the property on the receiver; if unsuccessful, look 1360 // Try looking up the property on the receiver; if unsuccessful, look
1361 // for a handler in the stub cache. 1361 // for a handler in the stub cache.
1362 Comment("DescriptorArray lookup"); 1362 Comment("DescriptorArray lookup");
1363 1363
1364 // Skip linear search if there are too many descriptors. 1364 // Skip linear search if there are too many descriptors.
1365 // TODO(jkummerow): Consider implementing binary search. 1365 // TODO(jkummerow): Consider implementing binary search.
1366 // See also TryLookupProperty() which has the same limitation. 1366 // See also TryLookupProperty() which has the same limitation.
1367 const int32_t kMaxLinear = 210; 1367 const int32_t kMaxLinear = 210;
1368 Label stub_cache(this); 1368 Label stub_cache(this);
1369 Node* bitfield3 = LoadMapBitField3(receiver_map); 1369 Node* bitfield3 = LoadMapBitField3(receiver_map);
1370 Node* nof = DecodeWord32<Map::NumberOfOwnDescriptorsBits>(bitfield3); 1370 Node* nof =
1371 GotoIf(Uint32LessThan(Int32Constant(kMaxLinear), nof), &stub_cache); 1371 DecodeWordFromWord32<Map::NumberOfOwnDescriptorsBits>(bitfield3);
1372 GotoIf(UintPtrGreaterThan(nof, IntPtrConstant(kMaxLinear)), &stub_cache);
1372 Node* descriptors = LoadMapDescriptors(receiver_map); 1373 Node* descriptors = LoadMapDescriptors(receiver_map);
1373 Variable var_name_index(this, MachineType::PointerRepresentation()); 1374 Variable var_name_index(this, MachineType::PointerRepresentation());
1374 Label if_descriptor_found(this); 1375 Label if_descriptor_found(this);
1375 DescriptorLookupLinear(key, descriptors, nof, &if_descriptor_found, 1376 DescriptorLookupLinear(key, descriptors, nof, &if_descriptor_found,
1376 &var_name_index, &stub_cache); 1377 &var_name_index, &stub_cache);
1377 1378
1378 Bind(&if_descriptor_found); 1379 Bind(&if_descriptor_found);
1379 { 1380 {
1380 LoadPropertyFromFastObject(receiver, receiver_map, descriptors, 1381 LoadPropertyFromFastObject(receiver, receiver_map, descriptors,
1381 var_name_index.value(), &var_details, 1382 var_name_index.value(), &var_details,
(...skipping 385 matching lines...) Expand 10 before | Expand all | Expand 10 after
1767 void AccessorAssembler::GenerateKeyedStoreICTrampolineTF( 1768 void AccessorAssembler::GenerateKeyedStoreICTrampolineTF(
1768 CodeAssemblerState* state, LanguageMode language_mode) { 1769 CodeAssemblerState* state, LanguageMode language_mode) {
1769 AccessorAssemblerImpl assembler(state); 1770 AccessorAssemblerImpl assembler(state);
1770 assembler.GenerateKeyedStoreICTrampolineTF(language_mode); 1771 assembler.GenerateKeyedStoreICTrampolineTF(language_mode);
1771 } 1772 }
1772 1773
1773 #undef ACCESSOR_ASSEMBLER_PUBLIC_INTERFACE 1774 #undef ACCESSOR_ASSEMBLER_PUBLIC_INTERFACE
1774 1775
1775 } // namespace internal 1776 } // namespace internal
1776 } // namespace v8 1777 } // namespace v8
OLDNEW
« no previous file with comments | « src/code-stubs.cc ('k') | src/ic/keyed-store-generic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698