Changed EBorderCollapse to an enum class and renamed its members

Changed EBorderCollapse to an enum class and renamed its members

Changed EBorderCollapse to an enum class and gave it an unsigned
underlying type. Also renamed its members to match its keywords from
CSSValueKeywords.in.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EBorderCollapse to be generated in
ComputedStyleBase.

BUG=628043
Committed: https://crrev.com/ae3bbc4f69ea52e4b505c8fcaffe4d4dca484c0c
Cr-Commit-Position: refs/heads/master@{#434602}

[sashab, 2016-11-23 05:05:45]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 05:06:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-11-23 05:11:36]

sashab@chromium.org changed reviewers:
+ aazzam@google.com

[aazzam, 2016-11-23 05:35:16]

lgtm

[aazzam, 2016-11-23 05:35:33]

lgtm

[sashab, 2016-11-23 05:37:33]

sashab@chromium.org changed reviewers:
+ nainar@chromium.org

[sashab, 2016-11-23 05:37:33]

nainar@ rs please :)

[nainar, 2016-11-23 05:45:09]

lgtm

[commit-bot: I haz the power, 2016-11-23 07:51:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 07:51:53]

Dry run: This issue passed the CQ dry run.

[sashab, 2016-11-28 03:13:17]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-11-28 03:13:17]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
aazzam@google.com
Link to the patchset: https://codereview.chromium.org/2528573002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-28 03:13:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 04:33:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480302797488380,
"parent_rev": "643ecc41da40cae3c0bf8bd73b998735520ce2bf", "commit_rev":
"2647e9a0441571becb3a2147ffa6f872334a2a96"}

[commit-bot: I haz the power, 2016-11-28 04:33:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-28 04:36:47]

Description was changed from

==========
Changed EBorderCollapse to an enum class and renamed its members

Changed EBorderCollapse to an enum class and gave it an unsigned
underlying type. Also renamed its members to match its keywords from
CSSValueKeywords.in.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EBorderCollapse to be generated in
ComputedStyleBase.

BUG=628043
==========

to

==========
Changed EBorderCollapse to an enum class and renamed its members

Changed EBorderCollapse to an enum class and gave it an unsigned
underlying type. Also renamed its members to match its keywords from
CSSValueKeywords.in.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EBorderCollapse to be generated in
ComputedStyleBase.

BUG=628043

Committed: https://crrev.com/ae3bbc4f69ea52e4b505c8fcaffe4d4dca484c0c
Cr-Commit-Position: refs/heads/master@{#434602}
==========

[commit-bot: I haz the power, 2016-11-28 04:36:49]

Patchset 3 (id:??) landed as
https://crrev.com/ae3bbc4f69ea52e4b505c8fcaffe4d4dca484c0c
Cr-Commit-Position: refs/heads/master@{#434602}