Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/bots/pub.py

Issue 252853002: Add support for running debug mode pkg, docs tests (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/pub.py
===================================================================
--- tools/bots/pub.py (revision 35364)
+++ tools/bots/pub.py (working copy)
@@ -15,13 +15,13 @@
import bot
-PUB_BUILDER = r'pub-(linux|mac|win)(-(russian))?'
+PUB_BUILDER = r'pub-(linux|mac|win)(-(russian))?(-(debug))?'
def PubConfig(name, is_buildbot):
"""Returns info for the current buildbot based on the name of the builder.
Currently, this is just:
- - mode: always "release"
+ - mode: "debug", "release"
- system: "linux", "mac", or "win"
"""
pub_pattern = re.match(PUB_BUILDER, name)
@@ -30,9 +30,10 @@
system = pub_pattern.group(1)
locale = pub_pattern.group(3)
+ mode = pub_pattern.group(5) or 'release'
if system == 'win': system = 'windows'
- return bot.BuildInfo('none', 'vm', 'release', system, checked=True,
+ return bot.BuildInfo('none', 'vm', mode, system, checked=True,
builder_tag=locale)
@@ -46,11 +47,14 @@
common_args = ['--write-test-outcome-log']
if build_info.builder_tag:
common_args.append('--builder-tag=%s' % build_info.builder_tag)
-
- bot.RunTest('pub', build_info,
- common_args + ['pub', 'pkg', 'docs'])
+
+ # Pub tests currently has a lot of timeouts when run in debug mode
Bill Hesse 2014/04/28 10:53:44 currently have
+ # See issue 18479
+ if build_info.mode == 'release':
+ bot.RunTest('pub', build_info,
+ common_args + ['pub', 'pkg', 'docs'])
- pkgbuild_build_info = bot.BuildInfo('none', 'vm', 'release',
+ pkgbuild_build_info = bot.BuildInfo('none', 'vm', build_info.mode,
build_info.system, checked=False)
bot.RunTest('pkgbuild_repo_pkgs', pkgbuild_build_info,
common_args + ['--append_logs', '--use-repository-packages', 'pkgbuild'])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698